Skip to content

fix(#403): No way to clear a selection: no Esc, no clear button, no select-all; Upload stay - #412

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-403
Oct 20, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-403

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #403

Esc on a row or the list clears a non-empty selection (onActionKey in itemActions.ts); the selection bar (desktop and phone sheet) gets a borderless 'Clear selection' icon button; the shortcuts dialog lists Esc; i18n added in all three locales. The #403 E2E test now deletes its folder afterwards so the shared home root stays under the list's 200-entry render limit, which had made the collision spec time out on mobile.

Driver gates (measured, not claimed)

  • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1187 passed, 0 failed | e2e: 605 passed, 0 failed
  • Red/green check on declared tests: e2e/selection-bar.spec.ts, e2e/polish.spec.ts
red/green output
RED without the change:
Usage:

        pnpm exec playwright show-trace test-results/selection-bar--403-Esc-and-77f92-ction-and-bring-Upload-back-mobile-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  4 failed
    [desktop-chrome] › e2e/polish.spec.ts:239:1 › in the trash and in a read-only share, no menu offers rename, move or upload (#116) 
    [desktop-chrome] › e2e/selection-bar.spec.ts:182:1 › #403 Esc and the bar's clear button clear the selection and bring Upload back 
    [mobile-chrome] › e2e/polish.spec.ts:239:1 › in the trash and in a read-only share, no menu offers rename, move or upload (#116) 
    [mobile-chrome] › e2e/selection-bar.spec.ts:182:1 › #403 Esc and the bar's clear button clear the selection and bring Upload back 


GREEN with the change:
e chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
$ node build.mjs


Running 4 tests using 1 worker

  ✓  1 [desktop-chrome] › e2e/polish.spec.ts:239:1 › in the trash and in a read-only share, no menu offers rename, move or upload (#116) (1.5s)
  ✓  2 [desktop-chrome] › e2e/selection-bar.spec.ts:182:1 › #403 Esc and the bar's clear button clear the selection and bring Upload back (760ms)
  ✓  3 [mobile-chrome] › e2e/polish.spec.ts:239:1 › in the trash and in a read-only share, no menu offers rename, move or upload (#116) (1.6s)
  ✓  4 [mobile-chrome] › e2e/selection-bar.spec.ts:182:1 › #403 Esc and the bar's clear button clear the selection and bring Upload back (851ms)

  4 passed (7.4s)

🤖 Generated with Claude Code

Esc on a row or the list clears a non-empty selection (onActionKey in itemActions.ts); the selection bar (desktop and phone sheet) gets a borderless 'Clear selection' icon button; the shortcuts dialog lists Esc; i18n added in all three locales. The #403 E2E test now deletes its folder afterwards so the shared home root stays under the list's 200-entry render limit, which had made the collision spec time out on mobile.

Refs #403

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BeSovereign
BeSovereign merged commit 3a765bc into main Oct 20, 2026
3 checks passed
@BeSovereign
BeSovereign deleted the fix/issue-403 branch October 20, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant