Skip to content

fix(#405): Phone: toast covers the selection sheet's last row; 'Move to trash' cannot be ta - #414

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-405
Oct 20, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-405

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #405

On phone width the toast's bottom offset now adds --selection-bar-height, which FolderPane already measures on the section that contains the toast, so the toast sits above the fixed selection sheet and 'Move to trash' stays tappable. New mobile E2E test checks the toast and sheet don't overlap and does a trial click on 'Move to trash'; DESIGN.md toast entry updated.

Driver gates (measured, not claimed)

  • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1187 passed, 0 failed | e2e: 607 passed, 0 failed
  • Red/green check on declared tests: e2e/toast-selection-bar.spec.ts
red/green output
RED without the change:
──────────────────────────────────────────────────────────────────────

    Error Context: test-results/toast-selection-bar--405-t-510ef-election-sheet-on-the-phone-mobile-chrome/error-context.md

    attachment #3: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/toast-selection-bar--405-t-510ef-election-sheet-on-the-phone-mobile-chrome/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/toast-selection-bar--405-t-510ef-election-sheet-on-the-phone-mobile-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  1 failed
    [mobile-chrome] › e2e/toast-selection-bar.spec.ts:9:1 › #405 the toast does not cover the selection sheet on the phone 
  1 skipped


GREEN with the change:
s an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.

(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
$ node build.mjs


Running 2 tests using 1 worker

  -  1 [desktop-chrome] › e2e/toast-selection-bar.spec.ts:9:1 › #405 the toast does not cover the selection sheet on the phone
  ✓  2 [mobile-chrome] › e2e/toast-selection-bar.spec.ts:9:1 › #405 the toast does not cover the selection sheet on the phone (1.0s)

  1 skipped
  1 passed (4.3s)

🤖 Generated with Claude Code

On phone width the toast's bottom offset now adds --selection-bar-height, which FolderPane already measures on the section that contains the toast, so the toast sits above the fixed selection sheet and 'Move to trash' stays tappable. New mobile E2E test checks the toast and sheet don't overlap and does a trial click on 'Move to trash'; DESIGN.md toast entry updated.

Refs #405

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BeSovereign
BeSovereign merged commit 7379d57 into main Oct 20, 2026
3 checks passed
@BeSovereign
BeSovereign deleted the fix/issue-405 branch October 20, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant