Repository navigation
fix(#405): Phone: toast covers the selection sheet's last row; 'Move to trash' cannot be ta - #414
Merged
Merged
Conversation
On phone width the toast's bottom offset now adds --selection-bar-height, which FolderPane already measures on the section that contains the toast, so the toast sits above the fixed selection sheet and 'Move to trash' stays tappable. New mobile E2E test checks the toast and sheet don't overlap and does a trial click on 'Move to trash'; DESIGN.md toast entry updated. Refs #405 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #405
On phone width the toast's bottom offset now adds --selection-bar-height, which FolderPane already measures on the section that contains the toast, so the toast sits above the fixed selection sheet and 'Move to trash' stays tappable. New mobile E2E test checks the toast and sheet don't overlap and does a trial click on 'Move to trash'; DESIGN.md toast entry updated.
Driver gates (measured, not claimed)
red/green output
🤖 Generated with Claude Code