Skip to content

fix(#406): Phone: a selected search result in a short folder stays hidden under the selecti - #415

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-406
Oct 20, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-406

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #406

focusRow/focusTile now scroll the focused row or tile fully into view (scrollIntoView nearest). Rows and tiles get scroll-margin-bottom of the phone's sheet height, or scroll-margin-top of the sticky toolbar's measured height on the desktop. FolderPane scrolls the focused item into view again once the sheet has been measured, because the ResizeObserver reports the height only after focus, so a search result in a short folder is no longer hidden under the sheet.

Driver gates (measured, not claimed)

  • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1187 passed, 0 failed | e2e: 609 passed, 0 failed
  • Red/green check on declared tests: e2e/select-above-sheet.spec.ts
red/green output
RED without the change:
hrome/error-context.md

    attachment #3: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/select-above-sheet--406-th-c086b-n-under-the-selection-sheet-mobile-chrome/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/select-above-sheet--406-th-c086b-n-under-the-selection-sheet-mobile-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  2 failed
    [mobile-chrome] › e2e/select-above-sheet.spec.ts:25:3 › #406 the selected list item of a short folder is not hidden under the selection sheet 
    [mobile-chrome] › e2e/select-above-sheet.spec.ts:25:3 › #406 the selected gallery item of a short folder is not hidden under the selection sheet 
  2 skipped


GREEN with the change:
ns/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
$ node build.mjs


Running 4 tests using 1 worker

  -  1 [desktop-chrome] › e2e/select-above-sheet.spec.ts:25:3 › #406 the selected list item of a short folder is not hidden under the selection sheet
  -  2 [desktop-chrome] › e2e/select-above-sheet.spec.ts:25:3 › #406 the selected gallery item of a short folder is not hidden under the selection sheet
  ✓  3 [mobile-chrome] › e2e/select-above-sheet.spec.ts:25:3 › #406 the selected list item of a short folder is not hidden under the selection sheet (1.4s)
  ✓  4 [mobile-chrome] › e2e/select-above-sheet.spec.ts:25:3 › #406 the selected gallery item of a short folder is not hidden under the selection sheet (1.3s)

  2 skipped
  2 passed (6.3s)

🤖 Generated with Claude Code

focusRow/focusTile now scroll the focused row or tile fully into view (scrollIntoView nearest). Rows and tiles get scroll-margin-bottom of the phone's sheet height, or scroll-margin-top of the sticky toolbar's measured height on the desktop. FolderPane scrolls the focused item into view again once the sheet has been measured, because the ResizeObserver reports the height only after focus, so a search result in a short folder is no longer hidden under the sheet.

Refs #406

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BeSovereign
BeSovereign merged commit 0098340 into main Oct 20, 2026
3 checks passed
@BeSovereign
BeSovereign deleted the fix/issue-406 branch October 20, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant