Repository navigation
fix(#418): Security: deleting a shared cloud folder in Files leaves shares, links and file - #428
Merged
Merged
Conversation
Deletes of cloud items through Files (sources route, duplicate finder, move jobs, migration cleanup, grantee deletes in cloud shares) now orphan shares, public links and file requests via the new orphanPathRefs/orphanDeleted (410, never revived). ShareBackend writes and version restores, plus cloud file-request creation and placement, first check that the shared item or folder still exists and answer NOT_FOUND, so no write recreates a vanished path. Adversarial and test-adversary reviews ran; the restore guard and tests for placement, cleanup, grantee delete and the source filter were added after them. Refs #418 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Security review (claude-fable-5-1): no blocking finding. No exploitable gap found. Orphaning keys come only from keysOf (owner-scoped, share-granted), run only after a successful provider delete; every write path into a share passes present(), file requests stat before creation and placement, after rate limiting. Hardening: present() untested for delete/move/copy/restoreRevision on a gone root; partial multi-path delete failure and Dropbox case-only deletes leave rows live (documented, no access gain); Drive 30 s path cache window documented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #418
Deletes of cloud items through Files (sources route, duplicate finder, move jobs, migration cleanup, grantee deletes in cloud shares) now orphan shares, public links and file requests via the new orphanPathRefs/orphanDeleted (410, never revived). ShareBackend writes and version restores, plus cloud file-request creation and placement, first check that the shared item or folder still exists and answer NOT_FOUND, so no write recreates a vanished path. Adversarial and test-adversary reviews ran; the restore guard and tests for placement, cleanup, grantee delete and the source filter were added after them.
Driver gates (measured, not claimed)
red/green output
🤖 Generated with Claude Code