Repository navigation
fix(#419): Security (low): 10,000 anonymous GETs to /auth/login block every sign-in for ten - #429
Merged
Merged
Conversation
Login starts are rate-limited per addressKey (30/min, a completed sign-in resets it), and live login attempts are capped at 50 per address, with the oldest evicted (migration 033 adds login_attempts.address); the global LOGIN_ATTEMPTS_MAX stays as the last resort, and the trade-off is recorded in DECISIONS/CONCEPTS. This round: eslint.config.js now ignores the generated playwright-report/, test-results/ and coverage/ output whose minified bundles failed lint; after the adversarial and test-adversary reviews, the completed-sign-in test uses its own address and the #255 test asserts no retry-after. Refs #419 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Security review (claude-fable-5-1): no blocking finding. No blocking defects. Per-address limiter and ceiling are correctly scoped; forget() only after a successful code exchange keyed on the stored address; SQL parameterised; tests fail when either guard is removed. Address key trusts the one-hop proxy (Traefik appends XFF), a pre-existing invariant; a /56 holder can still fill the global table (documented); client IPs now logged at warn. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #419
Login starts are rate-limited per addressKey (30/min, a completed sign-in resets it), and live login attempts are capped at 50 per address, with the oldest evicted (migration 033 adds login_attempts.address); the global LOGIN_ATTEMPTS_MAX stays as the last resort, and the trade-off is recorded in DECISIONS/CONCEPTS. This round: eslint.config.js now ignores the generated playwright-report/, test-results/ and coverage/ output whose minified bundles failed lint; after the adversarial and test-adversary reviews, the completed-sign-in test uses its own address and the #255 test asserts no retry-after.
Driver gates (measured, not claimed)
red/green output
🤖 Generated with Claude Code