Skip to content

fix(#420): Esc does not clear a selection made with the row checkbox - #430

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-420
Oct 20, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-420

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #420

The row checkbox (FileList) and the tile checkbox (GalleryGrid) now handle Esc themselves: it clears the selection through the same logic as #403 and moves the focus to that row or tile. In the list, the row's guard ignored keys from its own checkbox; in the gallery, the checkbox sits outside the tile, so Esc never reached the tile. A new Playwright test covers both views.

Driver gates (measured, not claimed)

  • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1203 passed, 0 failed | e2e: 618 passed, 0 failed
  • Red/green check on declared tests: e2e/selection-bar.spec.ts
red/green output
RED without the change:
election-bar--420-Esc-cle-400b4-th-the-row-or-tile-checkbox-mobile-chrome/error-context.md

    attachment #3: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/selection-bar--420-Esc-cle-400b4-th-the-row-or-tile-checkbox-mobile-chrome/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/selection-bar--420-Esc-cle-400b4-th-the-row-or-tile-checkbox-mobile-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  2 failed
    [desktop-chrome] › e2e/selection-bar.spec.ts:230:1 › #420 Esc clears a selection made with the row or tile checkbox 
    [mobile-chrome] › e2e/selection-bar.spec.ts:230:1 › #420 Esc clears a selection made with the row or tile checkbox 


GREEN with the change:
l.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.

(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
$ node build.mjs


Running 2 tests using 1 worker

  ✓  1 [desktop-chrome] › e2e/selection-bar.spec.ts:230:1 › #420 Esc clears a selection made with the row or tile checkbox (1.0s)
  ✓  2 [mobile-chrome] › e2e/selection-bar.spec.ts:230:1 › #420 Esc clears a selection made with the row or tile checkbox (1.1s)

  2 passed (5.3s)

🤖 Generated with Claude Code

The row checkbox (FileList) and the tile checkbox (GalleryGrid) now handle Esc themselves: it clears the selection through the same logic as #403 and moves the focus to that row or tile. In the list, the row's guard ignored keys from its own checkbox; in the gallery, the checkbox sits outside the tile, so Esc never reached the tile. A new Playwright test covers both views.

Refs #420

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BeSovereign
BeSovereign merged commit 1328540 into main Oct 20, 2026
3 checks passed
@BeSovereign
BeSovereign deleted the fix/issue-420 branch October 20, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant