Repository navigation
fix(#420): Esc does not clear a selection made with the row checkbox - #430
Merged
Merged
Conversation
The row checkbox (FileList) and the tile checkbox (GalleryGrid) now handle Esc themselves: it clears the selection through the same logic as #403 and moves the focus to that row or tile. In the list, the row's guard ignored keys from its own checkbox; in the gallery, the checkbox sits outside the tile, so Esc never reached the tile. A new Playwright test covers both views. Refs #420 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #420
The row checkbox (FileList) and the tile checkbox (GalleryGrid) now handle Esc themselves: it clears the selection through the same logic as #403 and moves the focus to that row or tile. In the list, the row's guard ignored keys from its own checkbox; in the gallery, the checkbox sits outside the tile, so Esc never reached the tile. A new Playwright test covers both views.
Driver gates (measured, not claimed)
red/green output
🤖 Generated with Claude Code