Added BooleanFormat option#51
Conversation
WalkthroughThis PR introduces a new BooleanFormat feature allowing customizable boolean output formatting in CSV generation. It adds a BooleanFormat enum with three options (Lowercase, PascalCase, Numeric), integrates the feature across JSON, List, and XML parsers, adds corresponding unit tests, and bumps the package version from 1.10.0 to 1.11.0. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Frends.CSV.Create/Frends.CSV.Create/Frends.CSV.Create.csproj (1)
3-16: Csproj is compliant, but Result class lacks Error property required by FT0011 validation.The
.csprojfile meets all coding guidelines: targets .NET 6, uses MIT license, and includes all required metadata fields (Version, Authors, Description, RepositoryUrl, GenerateDocumentationFile). The version bump to 1.11.0 is appropriate.The pipeline failure
FT0011: Task return type missing required propertiesis valid. TheResultclass inFrends.CSV.Create/Definitions/Result.cshas the requiredSuccessproperty but is missing theErrorproperty (which should containMessageandAdditionalInfofor error handling). Add this property to resolve the validation failure.
🤖 Fix all issues with AI agents
In `@Frends.CSV.Create/Frends.CSV.Create/Definitions/Options.cs`:
- Around line 41-46: Add the two required properties to the Options class:
define a Boolean ThrowErrorOnFailure { get; set; } and a string
ErrorMessageOnFailure { get; set; } (include XML doc comments and a DefaultValue
attribute for each) so the task framework can find them; place them alongside
the existing properties (e.g., next to BooleanFormat) and choose sensible
defaults via DefaultValue (e.g., false for ThrowErrorOnFailure or whatever your
framework expects) to satisfy CI.
Please review my changes :)
Review Checklist
Summary by CodeRabbit
New Features
BooleanFormatoption to customize boolean value representation in CSV files. Users can now choose from lowercase ("true"/"false"), PascalCase ("True"/"False"), or numeric ("1"/"0") formats.Tests
✏️ Tip: You can customize this high-level summary in your review settings.