Prepare FutrixData open source project#5
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a10b72698a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| asset_path="${OUTPUT_DIR}/${asset_name}" | ||
|
|
||
| echo "Building ${platform}/${arch} -> ${asset_name}" >&2 | ||
| GOOS="${platform}" GOARCH="${arch}" go build -trimpath -o "${work_dir}/${binary_name}" ./cmd/futrixdata-cli |
There was a problem hiding this comment.
The release script now builds ./cmd/futrixdata-cli, but this commit does not add that directory; repo-wide search only finds a single Go func main() in /workspace/FutrixData/main.go. This makes the new packaging CI job fail immediately because packaging/cli/tests/release-script.test.mjs executes this script and Go exits with stat .../cmd/futrixdata-cli: directory not found, so every PR/tag release path using this workflow is blocked until this points at an actual package or the command is added.
Useful? React with 👍 / 👎.
|
|
||
| NPM_TMP="${TMP_DIR}/npm-package" | ||
| mkdir -p "${NPM_TMP}" | ||
| cp -R packaging/npm/futrixdata-cli/. "${NPM_TMP}/" |
There was a problem hiding this comment.
After the binaries are built, this unconditional copy reads packaging/npm/futrixdata-cli/., but the commit contains no packaging/npm directory (checked with rg --files packaging). Once the preceding build path is fixed, the same release-script test and the tag release workflow will fail here before producing the npm tarball, so the template needs to be committed or this path needs to target the actual package source.
Useful? React with 👍 / 👎.
| RUN go mod download | ||
|
|
||
| COPY . . | ||
| RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o /out/futrixdata-http ./cmd/http |
There was a problem hiding this comment.
The new Dockerfile builds ./cmd/http, but there is no cmd/http package in the repository (the cmd tree was removed in this commit and repo-wide search finds no replacement HTTP main). Any user or deployment that tries to build the published container will fail at this layer with stat .../cmd/http: directory not found, so the Dockerfile should reference an existing entry point or include the intended HTTP command.
Useful? React with 👍 / 👎.
1 participant
Background
This PR replaces the previous public security-package snapshot with the cleaned FutrixData project source for open-source publication. The branch is based on FutrixDev/FutrixData main so it does not carry private development history.
Solution
Affected Files