Add pinch-to-zoom and auto-zoom to the QR scanner#259
Open
Merkost wants to merge 3 commits into
Open
Conversation
|
# Conflicts: # quickie/src/main/kotlin/io/github/g00fy2/quickie/QRScannerActivity.kt
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Add pinch-to-zoom and auto-zoom to the QR scanner
What
Two new opt-in options on
ScannerConfig.Builder:How
Preview+ImageAnalysisuse cases toLifecycleCameraController, which exposesisPinchToZoomEnablednatively.ZoomSuggestionOptionsis attached toBarcodeScannerOptions, with the zoom callback forwarded toLifecycleCameraController.setZoomRatio(...). Max zoom is read fromCameraInfo.zoomStateonce the camera is initialized.Closes #214.
Behavior changes to be aware of
false— existing apps see no change.1280×720analysis resolution was removed;LifecycleCameraControllerpicks its own default. ML Kit scanning still works in manual testing.Test plan
setUsePinchToZoom(true)→ preview zooms.setUseAutoZoom(true)→ camera zooms automatically.Notes
Buildermethods.Quick Startblock should get matching lines — happy to add them if you'd like.