Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/react-core/src/components/Backdrop/Backdrop.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { css } from '@patternfly/react-styles';
import styles from '@patternfly/react-styles/css/components/Backdrop/backdrop';
import stylesAnimated from '@patternfly/react-styles/css/components/BackdropAnimations/backdrop-animations';
import { useHasAnimations } from '../../helpers';

export interface BackdropProps extends React.HTMLProps<HTMLDivElement> {
Expand Down Expand Up @@ -28,9 +27,8 @@ export const Backdrop: React.FunctionComponent<BackdropProps> = ({
{...props}
className={css(
styles.backdrop,
hasAnimations && stylesAnimated.backdropAnimated,
hasAnimations && isVisible === true && stylesAnimated.backdropAnimatedVisible,
hasAnimations && isVisible !== true && stylesAnimated.backdropAnimatedHidden,
hasAnimations && styles.modifiers.animate,
hasAnimations && isVisible === true && styles.modifiers.show,
className
)}
>
Expand Down
7 changes: 3 additions & 4 deletions packages/react-core/src/components/Modal/ModalBox.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { css } from '@patternfly/react-styles';
import styles from '@patternfly/react-styles/css/components/ModalBox/modal-box';
import stylesAnimated from '@patternfly/react-styles/css/components/ModalAnimations/modal-animations';
// import stylesAnimated from '@patternfly/react-styles/css/components/ModalAnimations/modal-animations';
import topSpacer from '@patternfly/react-tokens/dist/esm/c_modal_box_m_align_top_spacer';

export interface ModalBoxProps extends React.HTMLProps<HTMLDivElement> {
Expand Down Expand Up @@ -53,9 +53,8 @@ export const ModalBox: React.FunctionComponent<ModalBoxProps> = ({
aria-modal="true"
className={css(
styles.modalBox,
hasAnimations && stylesAnimated.modalAnimated,
hasAnimations && isOpen === true && stylesAnimated.modalAnimatedOpen,
hasAnimations && isOpen !== true && stylesAnimated.modalAnimatedClosed,
hasAnimations && styles.modifiers.animate,
hasAnimations && isOpen === true && styles.modifiers.open,
className,
position === 'top' && styles.modifiers.alignTop,
variant === 'large' && styles.modifiers.lg,
Expand Down
33 changes: 31 additions & 2 deletions packages/react-core/src/components/Modal/ModalContent.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { useEffect, useState } from 'react';
import { FocusTrap } from '../../helpers';
import bullsEyeStyles from '@patternfly/react-styles/css/layouts/Bullseye/bullseye';
import { css } from '@patternfly/react-styles';
Expand Down Expand Up @@ -78,8 +79,20 @@ export const ModalContent: React.FunctionComponent<ModalContentProps> = ({
...props
}: ModalContentProps) => {
const hasAnimations = useHasAnimations(hasAnimationsProp);
// Keeps the modal in the DOM while the close animation runs. When animations are enabled we defer
// unmounting until the backdrop's transition ends (see onTransitionEnd below) instead of removing
// it immediately when isOpen becomes false.
const [isRendered, setIsRendered] = useState(isOpen);

if (!isOpen && !hasAnimations) {
useEffect(() => {
if (isOpen) {
setIsRendered(true);
} else if (!hasAnimations) {
setIsRendered(false);
}
}, [isOpen, hasAnimations]);

if (!isRendered) {
return null;
}

Expand Down Expand Up @@ -126,7 +139,23 @@ export const ModalContent: React.FunctionComponent<ModalContentProps> = ({
}

return (
<Backdrop className={css(backdropClassName)} id={backdropId} hasAnimations={hasAnimations} isVisible={isOpen}>
<Backdrop
className={css(backdropClassName)}
id={backdropId}
hasAnimations={hasAnimations}
isVisible={isOpen}
onTransitionEnd={
hasAnimations
? (event) => {
// Only unmount once the backdrop's own closing transition finishes. Guarding on the
// target prevents bubbled transitions from child elements from triggering this early.
if (!isOpen && event.target === event.currentTarget) {
setIsRendered(false);
}
}
: undefined
}
>
<FocusTrap
active={focusTrapActive}
focusTrapOptions={{
Expand Down
81 changes: 0 additions & 81 deletions packages/react-core/src/components/Modal/examples/Modal.css

This file was deleted.

1 change: 0 additions & 1 deletion packages/react-core/src/components/Modal/examples/Modal.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import RhUiWarningIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-warnin
import RhUiAttentionBellFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-attention-bell-fill-icon';
import RhUiQuestionMarkCircleIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-question-mark-circle-icon';
import formStyles from '@patternfly/react-styles/css/components/Form/form';
import './Modal.css';

## Examples

Expand Down