perf(build): narrow Core defaults and ACP role assembly - #2226
Merged
limityan merged 1 commit intoAug 12, 2026
Conversation
Keep Core product-full explicit, split ACP client/server roles, and guard every product consumer against capability-union regressions. BREAKING CHANGE: bitfun-core default features are now empty; consumers that require the full compatibility surface must enable product-full or select explicit owner features.
limityan
marked this pull request as ready for review
August 11, 2026 16:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-coredefault features empty and attachbase64,futures,regex, andtokio-utilto the exact runtime owners that consume thembitfun-acpinto additiveclientandserverroles while preserving the compatibility default asclient + serverArchitecture and compatibility
product-fullremains the explicit full-product assembly and its three-platform dependency closure is unchanged..bitfun/debug.logoverride whenworkspace-runtimeis enabled; its standalone owner now uses the configured path and compiles independently.bitfun-coreno longer enablesproduct-fullby default. Repository product consumers already select explicit owners. External path/git consumers that relied on the old implicit full surface must enableproduct-fullor select the owners they use.Dependency impact
Counts are deduplicated normal/build package instances for Windows x86_64, macOS aarch64, and Linux x86_64.
product-fullDesktop's package set is unchanged, but its ACP build no longer compiles 4,211 lines of server/runtime source. This PR does not claim a measured Desktop wall-clock improvement.
Cargo.lock: byte-for-byte unchanged; no packages added, upgraded, or removedVerification
node --test scripts/check-core-boundaries.test.mjs(92/92)pnpm run check:core-boundariescargo metadata --locked --offline --no-deps --format-version 1agent-runtime,debug-log,dispatch-store, andproduct-fullcargo check --locked --offline -p bitfun-cli --binscargo check --locked --offline -p bitfun-desktopgit diff --checkThree independent adversarial review passes covered architecture and upstream rebase compatibility, dependency/feature closure, and test/CI scope. The final rebased commit has no unresolved P0-P3 findings.