Repository navigation
Conversation
GCWing#3677 turned the Desktop capability set into an explicit list while GCWing#3591 added SshProxyCommandV1 to the enum. Each passed CI on its own, but together Desktop stopped advertising the new capability and the remote_surface capability and generated-registry tests fail on main.
3 tasks done
Collaborator
Author
|
Superseded by #3670, which merged the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main is red: #3677 made the Desktop peer capability set an explicit list, and #3591 (merged just before it) added
SshProxyCommandV1. Each PR passed CI on its own base, but on main Desktop no longer advertisesssh_proxy_command_v1, and two tests fail:remote_surface::capabilities::tests::desktop_advertises_a_superset_of_cli_except_its_delivery_pathremote_surface::tests::generated_registry_json_matches_compiled_registryThis adds the missing entry to
DESKTOP_CAPABILITIES. The generated registry already lists it (from #3591), so no regeneration is needed.Type and Areas
Type: regression fix
Areas: product-domains remote surface contract
Motivation / Impact
Restores main's CI and the Desktop advertisement of
ssh_proxy_command_v1. No controller gates on it yet, so there is no user-facing change.Verification
cargo test --locked -p openbitfun-product-domains --no-default-features remote_surface: 20 passed (on upstream/main without this change: 2 failed)pnpm run capabilities:check: passedChecklist