Skip to content

feat: CI - Add code rules checking action#3914

Open
arng40 wants to merge 106 commits intodevelopfrom
feat/dudes/add-code-rules
Open

feat: CI - Add code rules checking action#3914
arng40 wants to merge 106 commits intodevelopfrom
feat/dudes/add-code-rules

Conversation

@arng40
Copy link
Contributor

@arng40 arng40 commented Nov 18, 2025

This PR aim to create a new CI Target in order to ensure the use of the internal tool in geos and to promote the best coding practice.
First, this PR set up the CI check_code_rules and will ensure the use of : stdMap, stdUnorderedMap& stdVector
This PR will be merged after :

@arng40 arng40 self-assigned this Nov 18, 2025
@arng40 arng40 added type: CI Concerns github workflows or generic CI DO NOT MERGE ! flag: no rebaseline Does not require rebaseline labels Nov 18, 2025
@MelReyCG MelReyCG added ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs and removed DO NOT MERGE ! labels Dec 29, 2025
@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 53.20513% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.56%. Comparing base (2b691d5) to head (a46c814).

Files with missing lines Patch % Lines
src/coreComponents/mesh/graphs/GraphToolsMPI.cpp 0.00% 20 Missing ⚠️
...onents/linearAlgebra/multiscale/mesh/MeshLevel.cpp 0.00% 10 Missing ⚠️
...coreComponents/mesh/graphs/RLFGraphColoringMPI.cpp 0.00% 10 Missing ⚠️
...c/coreComponents/mesh/graphs/GraphColoringBase.cpp 18.18% 9 Missing ⚠️
...ents/linearAlgebra/multiscale/msrsb/MsrsbUtils.cpp 0.00% 4 Missing ⚠️
...oreComponents/mesh/generators/CellBlockManager.cpp 0.00% 3 Missing ⚠️
...rAlgebra/multiscale/mesh/coarsening/Coarsening.cpp 0.00% 2 Missing ⚠️
...ebra/multiscale/msrsb/MsrsbLevelBuilderCoupled.cpp 0.00% 2 Missing ⚠️
src/coreComponents/mesh/DomainPartition.hpp 0.00% 2 Missing ⚠️
...compositional/parameters/KValueFlashParameters.cpp 0.00% 1 Missing ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3914      +/-   ##
===========================================
- Coverage    58.87%   57.56%   -1.32%     
===========================================
  Files         1356     1353       -3     
  Lines       113234   112854     -380     
===========================================
- Hits         66668    64960    -1708     
- Misses       46566    47894    +1328     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@MelReyCG MelReyCG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put the rank at the right of the table?

vtkSmartPointer< vtkDataSet > mesh,
CellBlockManager & cellBlockManager )
{
std::cout << "ba"<< std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

babbbcbdbebf

Comment on lines +34 to +35
// This TEST is temporarily removed
// The error is located in getGraphNodeDegree() with an array out of bound
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a "TODO:"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline type: CI Concerns github workflows or generic CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants