Open
Conversation
pcolarco
added
enhancement
mathomp4
reviewed
Mar 26, 2026
| wet_removal_scheme: gocart ! default value | ||
|
|
||
| # Scavenging efficiency per bin [km-1] | ||
| # Scavenging efficency per bin [km-1] |
Member
There was a problem hiding this comment.
Looks like "efficiency" got misspelled to "efficency" in many files.
Contributor
Author
|
It used to say “effici.nc4y” after some bad “sed” scripting. That was an improvement.
But I fixed it and pushed the branch.
Pete
From: Matt Thompson ***@***.***>
Date: Thursday, March 26, 2026 at 3:16 PM
To: GEOS-ESM/GOCART ***@***.***>
Cc: Colarco, Peter R. (GSFC-6140) ***@***.***>, Author ***@***.***>
Subject: [EXTERNAL] [BULK] Re: [GEOS-ESM/GOCART] Feature/pcolarco/optics reorder (PR #400)
CAUTION: This email originated from outside of NASA. Please take care when clicking links or opening attachments. Use the "Report Message" button to report suspicious messages to the NASA SOC.
@mathomp4 commented on this pull request.
________________________________
In ESMF/GOCART2G_GridComp/CA2G_GridComp/CA2G_instance_CA.bc.rc<#400?email_source=notifications&email_token=ANW73YDYTY6CTABEBDLRJH34SV6ZRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBRGY3TQNBVGIZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K64DSL5ZGK5TJMV3V6Y3MNFRWW#discussion_r2997157431>:
@@ -23,13 +23,13 @@ time_days_chemical_destruction: -1. -1.
# Wet Removal Scheme Option | gocart, ufs
wet_removal_scheme: gocart ! default value
-# Scavenging efficiency per bin [km-1]
+# Scavenging efficency per bin [km-1]
Looks like "efficiency" got misspelled to "efficency" in many files.
—
Reply to this email directly, view it on GitHub<#400?email_source=notifications&email_token=ANW73YH7CF4EQL5VLHOWSUL4SV6ZRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBRGY3TQNBVGIZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2L24DSL5ZGK5TJMV3V63TPORUWM2LDMF2GS33OONPWG3DJMNVQ#pullrequestreview-4016784523>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANW73YDQYT5QDOKR2CWDIA34SV6ZRAVCNFSM6AAAAACW7IA3SGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DAMJWG44DINJSGM>.
You are receiving this because you authored the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change promotes the dimension reordering and renaming introduced by Weiyuan for the new GEOSmie generated aerosol optical property LUTs (effectively deprecates #302). Tested with refactored version of v0.0.0 optical tables produces a zero-diff result. This version changes the aerosol LUTs in the instance.rc files to point to GEOSmie produced v2.x.x optical tables.