Open
Conversation
Author
|
@GLips any thoughts? 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! 🙂
Not even a month has passed. 😁
I'm not super happy about
execpollutingconfig.tsto skipconsole.log's, but I'm not sure whether it is a good idea to overhaul more for such simple addition. 🤔Also not super happy about having to have a compatibility adapter for
startServer, but I've ran out of ideas for now, maybe tomorrow I'll have better ones. 😁Just wanted to avoid using
process.argvdirectly and rely on yargs entirely. 🤔Let me know if it makes sense to add example of using
-etoREADME.md, or in--helpfor users that are not aware of output piping likefigma-server-mcp -e "figma-link" > figma-node.yaml.I tried to avoid adding more arguments like
--output. 🙂Also figma links could contain
&which would run whatever after&as a "command", so suggesting quoting figma link probably makes sense as well. 🤔Also out of scope, but I checked out if there's some solution to the
process.argvwith type inference and it appears there is one. 🤔https://bloomberg.github.io/stricli/docs/getting-started/alternatives
Feel free to do anything with the PR.
Let me know your thoughts 🙂
Thanks.