Skip to content

GPII-4049: Volume Control v3#203

Open
Karadaliev wants to merge 3 commits into
GPII:masterfrom
krisYanachkov:GPII-4049-New
Open

GPII-4049: Volume Control v3#203
Karadaliev wants to merge 3 commits into
GPII:masterfrom
krisYanachkov:GPII-4049-New

Conversation

@Karadaliev

Copy link
Copy Markdown
Contributor

Moving from a settings based Volume/Mute control, to one that uses Windows real-time commands. With that we no-longer trying to read the current volume, and don't track it internally as well. Just sending volume up/down and mute commands on key presses.

Notes:

  • As we don't have the functionality to read Windows's mute state we don't know it and assume that it's not muted. So if Windows's muted and you open QSS looks like it's not, so when you click the "Mute" button it will unmute Windows, but will show that it's muted in QSS (toggle on, and the button will show that it's muted). So the buttons will work properly, but the UX will be reversed. Gregg knows about this, and accepted it in order to finish this quicker.
  • If you click on the "Mute" button this will toggle Windows's mute, and show the Mute state in QSS (the button will be red, and button's text will change). If you click Mute again this will reverse, the same goes if you click Volume Up as well, so the Volume Up will act as Unmute too.

@gpii-bot

gpii-bot commented Jun 1, 2020

Copy link
Copy Markdown

Could one of the admins verify that these changes are reasonable to test? If so, please reply with "ok to test".

@Karadaliev Karadaliev marked this pull request as ready for review June 3, 2020 08:02
@Karadaliev

Copy link
Copy Markdown
Contributor Author

@amb26 @javihernandez This is ready for testing and review! 🛩️

@javihernandez

Copy link
Copy Markdown
Member

ok to test

@gpii-bot

gpii-bot commented Jun 3, 2020

Copy link
Copy Markdown

CI job passed: https://ci.gpii.net/job/gpii-app-tests/1153/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants