Skip to content

Handle Docker multi-protocol port bindings when creating challenge containers#576

Open
Copilot wants to merge 5 commits intodevelopfrom
copilot/fix-port-53-container-creation
Open

Handle Docker multi-protocol port bindings when creating challenge containers#576
Copilot wants to merge 5 commits intodevelopfrom
copilot/fix-port-53-container-creation

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 27, 2026

  • Review the new PR comments and identify the exact requested follow-up changes
  • Update DockerManager to use is [] for the non-null empty binding check
  • Remove the DockerManager unit test file per review feedback
  • Re-run backend unit tests to validate the follow-up changes
  • Review the final diff for patch cleanliness

Copilot AI linked an issue Apr 27, 2026 that may be closed by this pull request
1 task
Copilot AI changed the title [WIP] Fix port 53 issue causing container creation failures Handle Docker multi-protocol port bindings when creating challenge containers Apr 27, 2026
Copilot AI requested a review from hez2010 April 27, 2026 14:06
Comment thread src/GZCTF/Services/Container/Manager/DockerManager.cs Outdated
Comment thread src/GZCTF.Test/UnitTests/Services/Container/DockerManagerTests.cs Outdated
Agent-Logs-Url: https://github.com/GZTimeWalker/GZCTF/sessions/237b27d4-457f-478f-91af-61e6207b784b

Co-authored-by: hez2010 <14960345+hez2010@users.noreply.github.com>
Copilot AI requested a review from hez2010 April 27, 2026 14:14
@hez2010 hez2010 marked this pull request as ready for review April 27, 2026 15:04
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 47.36842% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.31%. Comparing base (4ba7b62) to head (9ac70ee).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
.../GZCTF/Services/Container/Manager/DockerManager.cs 47.36% 6 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #576      +/-   ##
===========================================
+ Coverage    59.11%   59.31%   +0.19%     
===========================================
  Files          184      184              
  Lines         9371     9386      +15     
  Branches      1137     1141       +4     
===========================================
+ Hits          5540     5567      +27     
+ Misses        3409     3395      -14     
- Partials       422      424       +2     
Files with missing lines Coverage Δ
.../GZCTF/Services/Container/Manager/DockerManager.cs 52.88% <47.36%> (-1.01%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port 53 bricks Container Creation

2 participants