state ownership refactor: per-class narrow/merge_ row semantics (StateRowMixin)#519
Draft
ElmoPA wants to merge 1 commit into
Draft
state ownership refactor: per-class narrow/merge_ row semantics (StateRowMixin)#519ElmoPA wants to merge 1 commit into
ElmoPA wants to merge 1 commit into
Conversation
…eRowMixin) Every stage-state dataclass owns its row slice/write-back (generic dataclasses.fields walk; materialize-on-merge; always-on post-merge invariant; loud failures on unhandled fields). The ~270-line central _slice_*/_scatter_* switchboard in stages.py becomes thin delegation. Fixes (audit-confirmed): grab_prev_end prev_x silently dropped at every slice/scatter boundary -> nested chunkers rolled out with no_prev on EVERY chunk (eval-only train/inference mismatch). Now eager prev_x/prev_x_valid, in-place carry updates, per-row validity read. Also: msublatent_state allocated, reg_trunk_state gate widened to down_interface=register. Training path untouched. tests_state_roundtrip.py: 15/15. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CjuZ3zwWaCeQQigxiNuzGw
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every stage-state dataclass owns its row slice/write-back (generic
dataclasses.fields walk; materialize-on-merge; always-on post-merge
invariant; loud failures on unhandled fields). The ~270-line central
slice/scatter switchboard in stages.py becomes thin delegation.
Fixes (audit-confirmed): grab_prev_end prev_x silently dropped at every
slice/scatter boundary -> nested chunkers rolled out with no_prev on EVERY
chunk (eval-only train/inference mismatch). Now eager prev_x/prev_x_valid,
in-place carry updates, per-row validity read. Also: msublatent_state
allocated, reg_trunk_state gate widened to down_interface=register.
Training path untouched. tests_state_roundtrip.py: 15/15.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01CjuZ3zwWaCeQQigxiNuzGw