Repository navigation
design: regroup design.pen canvas and make screens reuse components - #702
Open
ValgulNecron wants to merge 10 commits into
Open
ValgulNecron wants to merge 10 commits into
ValgulNecron wants to merge 10 commits into
Conversation
Spec 022 FR-042 (T111-T113, T115, T116): two daily-count tables, daily_install_version and daily_version_change, written in the extended ingest transaction; semver ordering through golang.org/x/mod/semver (non-semver labels are unordered, OD-8); and extended.versionTrend in the views, with stale counted against the newest semver in the range, pre-releases included (OD-7, OD-10). New tests in versiontrend_test.go. Also renumber the Phase 11 tasks from T101-T110 to T111-T120: the amendment reused IDs already taken by Phase 9b. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
Rename the basic "Versions" card to "Reports by version" (OD-9), add the "Versions by install" card the template already renders, and add the "Version trend" card under it (FR-042): upgraded, downgraded and changed (unordered) panels on one shared scale, and stale installs on a scale of their own. New chart/series-3 (green) and chart/series-4 (amber) tokens pass the dataviz validator in both modes. Export of i0xK1E and variables.json in the same commit (rules 1, 2). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YUYPbMEUrfpqzc7dQtx2Wa Signed-off-by: valgulnecron <39313199+ValgulNecron@users.noreply.github.com>
Follow the T114 design: the basic chart is titled "Reports by version", and a "Version trend" card sits under "Versions by install". Its three change panels share one scale; stale installs get a full-width chart of their own, labelled with the newest release. "View as table" swaps the card for one Day/Upgraded/Downgraded/Changed (unordered)/Stale table. Column charts take a layout, so the trend panels render their axis text near 11px, and two new series classes (s3 green, s4 amber) come with light and dark tokens. No inline style or script (CSP). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YUYPbMEUrfpqzc7dQtx2Wa Signed-off-by: valgulnecron <39313199+ValgulNecron@users.noreply.github.com>
…022 T118) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
…dth (spec 022) The full-width "Versions by install" card stretched its 600-unit bar chart to the page width, so its labels rendered near 28px. It now draws a 1320-unit layout on wide screens. The stale panel of the version trend gains a panel-width layout for screens up to 720px, where the 1320-unit chart shrank its text to about 4px. CSS picks the layout, so the CSP-locked pages still need no JavaScript. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
Reports from a central or standalone panel count every managed cluster (OD-11), skip clusters that can't be reached and still go out on schedule (OD-12), and carry a cluster/standalone deployment marker in a new extended schema version (OD-13). Adds FR-043 to FR-045, US5 scenario 10, SC-018, research R23, plan slice 7 and Phase 12 tasks T121 to T127. OD-14 (older reports in the breakdown) and OD-15 (environment fields on a standalone panel) are open, so Phase 12 is blocked until they are ruled. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
…d clusters) Kubernetes versions and distributions become sets across the reachable managed clusters, as architectures already are. OD-16 (node band across clusters) is open. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
pen-canvas-layout describes how design.pen is organised: component boards at the top, one row per page in dashboard navigation order, variants left to right. check-layout.js verifies it. pen-componentize runs after a design pass: audit.js finds copies of existing components, hand-built controls and repeated structures, and promote.js turns a repeated structure into a component, replacing an occurrence only when the resolved instance matches it exactly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gp4RpCT35NNDCL3dSiNn7s Signed-off-by: valgulnecron <39313199+ValgulNecron@users.noreply.github.com>
Canvas: every reusable component sits on a board at the top (HeroUI library and a new transparent "Gameplane: App Components" board with nine sections); every screen sits in one row per page, in dashboard navigation order, with its variants to the right (57 rows, 161 roots). The empty HeroUI Modal instance o6u1PG moved onto the HeroUI board. Components: hand-built nav, header and login copies now use the shell components; 176 hand-built buttons, chips, inputs and pills became component instances with their labels, icons and monospace fonts kept; 14 repeated page blocks and 5 small controls became components. The Error Banner gained the alert icon the app renders, the Admin Settings Nav marks the active item's text, and instances that still showed "Button" or "Placeholder" carry the app's labels. Exports: 93 JSON + 95 PNG re-exported, positions of every other export patched, MANIFEST entries added. check-layout.js reports no issues. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gp4RpCT35NNDCL3dSiNn7s Signed-off-by: valgulnecron <39313199+ValgulNecron@users.noreply.github.com>
ValgulNecron
added
area: web
|
Important Review skippedToo many files! This PR contains 299 files, which is 199 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configuration
⛔ Files ignored due to path filters: 98
📒 Files selected for processing: 299
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CI Report - c3075afrun 38659015351 - attempt 1 0 failed - 23 passed - 9 skipped - 89m27s elapsed Coverageno coverage/* commit statuses found on c3075af Changed
Slowest jobs
e2e buckets run
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reorganises the
design.pencanvas and makes its screens use components instead of hand-built copies. Adds two skills that keep it that way.Canvas regroup
LtgNm), the imported library;i7OTip, new, transparent fill), with 105 components in nine sections, from Shell & navigation to Page blocks.check-layout.jsreports NO ISSUES.Modalinstanceo6u1PGmoved onto the HeroUI board as a usage example.Component reuse
hLB9ZanddQV9N;nNGDX,QgW58andzqzr4;FtdkI;loginCardSsocomponent onljdA5.web/src:Gameplane/Error Bannergained the alert icon thatErrorBanner.tsxrenders;Skills (
.claude/skills/)pen-canvas-layout: canvas organisation rules, procedures and thecheck-layout.jsverifier.pen-componentize: the post-design pass.audit.jsfinds detached copies, hand-built controls and repeated structures.promote.js(dry run, then exact-match promotion) turns repeated structures into components.Exports
x/ypatched to its new position.Intended visual differences
hLB9ZanddQV9Nshow the server-settings sub nav like the other 29 settings screens and the app: centred labels, no icons.Left for a design decision (audit findings not changed)
EZFW0,o4LH8W,Hy9r0,sSISK) build their Game Status and Quick Actions blocks differently from the new components.vUqMl's code block resembles YAML Block.IdbiB,O5kaV) and inY5cmvI.Test plan
check-layout.js: NO ISSUES (226 roots, 282 board components, 57 rows, 161 screens).audit.jsre-run. Remaining findings are listed above.🤖 Generated with Claude Code
https://claude.ai/code/session_01Gp4RpCT35NNDCL3dSiNn7s