Repository navigation
fix(docs): route the dashboard tour page - #19
Merged
Merged
Conversation
The [slug] route filtered dashboard-tour out of getStaticPaths while the sidebar, docs index, prev/next cards and Features page still linked to it, so /docs/dashboard-tour/ returned a 404. Generate it like every other doc. Fixes #8 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
/docs/dashboard-tour/returned a 404, while the sidebar on every docs page, the "Next" card on Install with Helm, the "Previous" card on Comparison, the docs index and two Features rows all linked to it.After: the Dashboard tour page is built and every one of those links opens it.
src/pages/docs/[slug].astrofiltereddashboard-tourout ofgetStaticPaths()(left over from the docs shell scaffold), so the page was never generated even thoughgetOrderedDocs()kept it in the navigation. This takes option 1 from the issue: the filter is removed and the route is generated like every other doc.How:
getStaticPaths()now maps every ordered doc directly, using the map index for prev/next instead of afindIndexlookup. The page content was checked against theScreen/Docs — Dashboard Tourframe (website-export/json/X0DeYH.json): same sections, lists, quick reference and covers, so no design change is needed.npm run buildnow emitsdist/docs/dashboard-tour/index.html(99 pages);npm run checkreports 0 errors.Not changed here:
[slug].astrostill ignores thenext:frontmatter override, so the tour's "Next" card points at Comparison (sequence order) rather than Create your first server as in the design. That is handled in #20.Fixes #8
🤖 Generated with Claude Code