Repository navigation
fix(docs): stop quick-reference boxes overlapping and double-numbering - #22
Merged
Merged
Conversation
DocsQuickReference renders its label as an h3 inside .docs-prose, whose h3 rule (margin-bottom: -16px) pulled the label over the first step. Render the label as a div so prose heading styles don't apply. The component already numbers each item (01, 02, ...), but 147 items in 48 docs pages also carried a hand-written "01 " prefix, so steps showed as "01 01 ...". Strip the duplicate prefixes from the content; every prefix matched its position, so the displayed numbers are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: in every docs quick-reference box (for example "FIRST OPERATING LOOP" on Dashboard tour), the label was drawn on top of the first step, and steps were numbered twice ("01 01 Choose a cluster and namespace").
After: the label sits above the steps in the accent colour, and each step shows one number ("01 Choose a cluster and namespace"), matching the design frames (e.g.
X0DeYH,e8fTgD,o5zdzdinwebsite-export/json/).How:
DocsQuickReference.astrorendered its label as an<h3>inside.docs-prose, and the unlayered.docs-prose h3rule (margin-bottom: -16px, 14px, foreground colour) beat the component's Tailwind utilities, pulling the label down over the first item. The label is now a<div>, so the prose heading rule no longer applies.01prefix. A script stripped those prefixes; every one matched its position, so displayed numbers are unchanged. Items that had no prefix were already numbered once by the component.npm run build(99 pages) andnpm run check(0 errors) pass locally; the rendered box was checked in Chromium.🤖 Generated with Claude Code