Skip to content

Issue#38 Add targeted MySQL↔BigQuery CI coverage#43

Merged
ramyamasani merged 6 commits into
masterfrom
bq_issue_38
May 19, 2026
Merged

Issue#38 Add targeted MySQL↔BigQuery CI coverage#43
ramyamasani merged 6 commits into
masterfrom
bq_issue_38

Conversation

@kantselovich
Copy link
Copy Markdown

@kantselovich kantselovich commented Apr 27, 2026

Fixes #38

Copy link
Copy Markdown

@orca-security-us orca-security-us Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the BigQuery database connector to automatically configure a default dataset in the query job configuration and adds BigQuery-related environment variables to the development environment file. Feedback includes a recommendation to safely handle the query job configuration to avoid potential TypeErrors when overlapping with keyword arguments, and a suggestion to use placeholders in the environment file instead of hardcoded local paths and project IDs to improve portability.

Comment thread data_diff/databases/bigquery.py
Comment thread dev/dev.env Outdated
@kantselovich kantselovich changed the title Bq issue 38 BQ Tests - Issue 38 Apr 28, 2026
@ramyamasani ramyamasani changed the title BQ Tests - Issue 38 Issue#38 Add targeted MySQL↔BigQuery CI coverage May 8, 2026
@ramyamasani ramyamasani force-pushed the bq_issue_38 branch 5 times, most recently from b0f32c9 to 1d15921 Compare May 12, 2026 19:22
Copy link
Copy Markdown

@orca-security-us orca-security-us Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Warning Vulnerabilities high 1   medium 0   low 0   info 0 View in Orca
☢️ The following Vulnerabilities (CVEs) have been detected
PACKAGE FILE CVE ID INSTALLED VERSION FIXED VERSION
high setuptools ./uv.lock CVE-2025-47273 70.3.0 78.1.1 View in code

Note: The scan should have failed if no policies were configured in warn-only mode.

@kantselovich
Copy link
Copy Markdown
Author

+1 @ramyamasani Nice work here.

But I cannot approve my own PR, however you can add + 1 :-)

@ChaosHour ChaosHour self-requested a review May 19, 2026 02:20
@ramyamasani ramyamasani merged commit edae9b5 into master May 19, 2026
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add targeted MySQL↔BigQuery CI coverage

4 participants