Issue#38 Add targeted MySQL↔BigQuery CI coverage#43
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
There was a problem hiding this comment.
Code Review
This pull request updates the BigQuery database connector to automatically configure a default dataset in the query job configuration and adds BigQuery-related environment variables to the development environment file. Feedback includes a recommendation to safely handle the query job configuration to avoid potential TypeErrors when overlapping with keyword arguments, and a suggestion to use placeholders in the environment file instead of hardcoded local paths and project IDs to improve portability.
006cb67 to
7386ff7
Compare
b0f32c9 to
1d15921
Compare
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
☢️ The following Vulnerabilities (CVEs) have been detected
| PACKAGE | FILE | CVE ID | INSTALLED VERSION | FIXED VERSION | ||
|---|---|---|---|---|---|---|
| setuptools | ./uv.lock | CVE-2025-47273 | 70.3.0 | 78.1.1 | View in code |
Note: The scan should have failed if no policies were configured in warn-only mode.
|
+1 @ramyamasani Nice work here. But I cannot approve my own PR, however you can add + 1 :-) |
Fixes #38