Repository navigation
test: check the large graph's failure against the graph viewport, not the window - #9
Merged
Merged
Conversation
… the window The large-graph test asserted that the failing node was in the browser window. The app centres the failure in the graph viewport, which at 1280x720 starts around y=505 and runs below the fold, so the test passed only while part of the node stayed above the window's edge. The tabs added above the graph wrap to another row with wider fonts; with DejaVu Sans (Linux Playwright image) the node fell entirely below the fold and the test failed every time, as in the E2E run on main at e57926c. - expectOpenOnFailure: bring the graph viewport into view, then require the whole node to be visible and centred in the viewport (within 2 px). - New test: the same check in a 1280x600 window, where the old assertion fails on every platform. App code is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GauJosh
added a commit
that referenced
this pull request
Oct 29, 2026
Brings in the large-graph E2E fix (#9) so the hosting branch is validated against the current main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the E2E failure on
mainat e57926c (run 40910770495):explorer.spec.ts"large graph: opens readable on the failure…", nodedef:s6-j3not in viewport, ratio 0.Cause
The app centres the failing node in the graph viewport; the test checked it against the browser window. At 1280×720 the graph viewport starts around y≈505 and extends below the fold, so the test passed only while part of the node stayed above the window edge. The tabs added above the graph in this release wrap onto another row with wider fonts, pushing the graph down.
Reproduced in the Playwright Linux image (v1.63.0-noble) with
fonts-dejavu-core: fails 5/5 at e57926c, passes 5/5 at e76ec44. Also fails on Windows at 1280×600.Change (test only; no app code)
expectOpenOnFailure: scroll the graph viewport into view, then require the whole node visible (ratio: 1) and centred in the viewport within 2 px (stricter than the previous any-pixel check).Local validation
🤖 Generated with Claude Code