Repository navigation
Conversation
Grok's shell tool is run_terminal_command and its result leaf is output_for_prompt. This host maps those into the existing adapter, registers the tool in the deployment manifest, and leaves the Guardian, the bridge, mapping.yaml, and the Claude Code shim unchanged. Live Grok 1.0.62 against a local Guardian denied echo rm -rf / as destructive_shell_command_blocked and allowed echo dogfood-allow. Co-authored-by: Grok Build <noreply@x.ai> Signed-off-by: antman1p <antman1p@gmail.com>
antman1p
requested review from
GangGreenTemperTatum,
afogel,
artmaro,
bar-capsule,
fewdisc,
mamicidal,
rocklambros and
sclintonowasp
as code owners
October 17, 2026 12:38
|
This pull request's description says it closes #108, which is on the project roadmap. When it merges, GitHub closes that issue and the roadmap counts it as delivered. Please confirm the change delivers the whole issue before merging. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds a third AGT host, Grok Build TUI, as a subprocess shim against the existing host adapter. The Guardian, the AGT bridge,
mapping.yaml,policy/lib, and the Claude Code shim are unchanged.Grok's measured payload (1.0.25 in #107, rechecked live on 1.0.62) uses
run_terminal_commandand a taggedtool_responsewhose model-facing leaf isoutput_for_prompt. Nativedeferon PreToolUse renders asdefer. The result gate patchesoutput_for_promptinside the tagged object so Grok does not drop the replacement.policy/manifest.yamlregistersrun_terminal_commandwithsecurity_labels: [shell], additive, so the stock pattern rule can evaluate it instead of failing closed astool_unknown.Parked, documented in the host README:
tool_response.outputis a byte array sibling ofoutput_for_prompt. A redaction patches the model-facing leaf and leaves the byte array as it was.Which issue does this implement
Closes #108
Refs #107
Base branch
integration, because this touches the specification, schemas, a referenceimplementation, an adapter, tests, or CI
main, because every changed path is on the documentation lane allowlist inCONTRIBUTING.md
Type of change
I tested this
uv run pytest -vpasses on my machineuv run mkdocs build --strictpasses on my machineFrom
reference-implementations/agt/:bun run typecheckis cleanbun test: 1285 pass, 1 skip, 0 fail across 77 filesbun test hosts/grok: 51 pass, 0 failpolicy/lib,mapping.yaml, Claude Code source) are unchanged in the working tree.bun run verify:zero-diffexits 1 in this repository becauseslice/v4is gone, which the AGT README already records.Live Grok 1.0.62, hook copied to
~/.grok/hooks/acs-agt.json, Guardian on 8787:echo rm -rf /denied asdestructive_shell_command_blockedat offset 5, tool namerun_terminal_command, nottool_unknownecho dogfood-allowallowed onsteps/toolCallRequestandsteps/toolCallResult; Grok printeddogfood-allowRoot:
uv run pytest -v918 passed, 1 skipped.uv run mkdocs build --strictpasses.Checklist
git commit -s(required by the DCO)Security
This change adds a governance hook for Grok's shell tool. It does not change Guardian policy.
The negotiated failure posture remains
proceed. If the Guardian is down, PreToolUse fail-opens after an audit entry, same as the other hosts.A redaction at the result gate patches
output_for_promptand does not mirror the byte-arrayoutputsibling. That residual is documented inhosts/grok/README.mdandgrok.hookmap.yaml.