Skip to content

fix: use ArgumentList for Client.exe launch (paths with spaces) #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JusterZhu merged 1 commit into from
May 20, 2026
Merged

fix: use ArgumentList for Client.exe launch (paths with spaces) #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/Services/SimulationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,15 @@ public async Task<SimulationResult> RunAsync(
// 5. Run client
Log("STEP 5: Running Client.exe", progress);
var clientExe = Path.Combine(config.OutputDirectory, "Client.exe");
var clientArgs = $"--server-url {_server.BaseUrl} --install-path \"{config.AppDirectory}\" --current-version {config.CurrentVersion} --app-secret {config.AppSecretKey} --product-id {config.ProductId} --app-name Upgrade.exe";
var clientArgs = new List<string>
{
"--server-url", _server.BaseUrl,
"--install-path", config.AppDirectory,
"--current-version", config.CurrentVersion,
"--app-secret", config.AppSecretKey,
"--product-id", config.ProductId,
"--app-name", "Upgrade.exe"
};
var clientResult = await RunExe(clientExe, clientArgs, ct);
Log(clientResult.Output, progress);

Expand Down Expand Up @@ -163,14 +171,16 @@ private void Validate(SimulateConfigModel config)
catch { throw new InvalidOperationException("dotnet CLI not found"); }
}

private async Task<(bool Success, string Output)> RunExe(string exePath, string arguments, CancellationToken ct)
private async Task<(bool Success, string Output)> RunExe(string exePath, List<string> arguments, CancellationToken ct)
{
var psi = new ProcessStartInfo(exePath, arguments)
var psi = new ProcessStartInfo(exePath)
{
RedirectStandardOutput = true, RedirectStandardError = true,
StandardOutputEncoding = Encoding.UTF8, StandardErrorEncoding = Encoding.UTF8,
UseShellExecute = false, CreateNoWindow = true
};
foreach (var arg in arguments)
psi.ArgumentList.Add(arg);
using var p = Process.Start(psi)!;
var output = new StringBuilder();
var readTask = Task.Run(async () => { while (!p.StandardOutput.EndOfStream) output.AppendLine(await p.StandardOutput.ReadLineAsync(ct)); }, ct);
Expand Down
Loading