fix: generate simulation report on both success and failure#63
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the simulation workflow so simulation_report.md is generated not only on successful runs, but also on failures and unexpected exceptions, improving post-run diagnostics.
Changes:
- Move result logging + report generation outside the success-only branch so failures also produce a report.
- Add exception handling that attempts to generate a failure report when an exception is thrown.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+112
to
+117
| { | ||
| Status = $"Error: {ex.Message}"; | ||
| L($"FATAL: {ex}"); | ||
| var failResult = new SimulationResult { Success = false, ErrorMessage = ex.Message }; | ||
| var reportPath = await _report.GenerateAsync(Config, failResult, Config.OutputDirectory); | ||
| L(_loc.T("Sim.Report", reportPath)); |
Comment on lines
+108
to
+117
| var reportPath = await _report.GenerateAsync(Config, result, Config.OutputDirectory); | ||
| L(_loc.T("Sim.Report", reportPath)); | ||
| } | ||
| catch (Exception ex) | ||
| { | ||
| Status = $"Error: {ex.Message}"; | ||
| L($"FATAL: {ex}"); | ||
| var failResult = new SimulationResult { Success = false, ErrorMessage = ex.Message }; | ||
| var reportPath = await _report.GenerateAsync(Config, failResult, Config.OutputDirectory); | ||
| L(_loc.T("Sim.Report", reportPath)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate simulation_report.md in all cases: success, failure, and exception.
Build: 0 errors