Fix/install path simulation dir#67
Closed
JusterZhu wants to merge 2 commits into
Closed
Conversation
Client.exe receives --install-path to determine where Upgrade.exe lives for StartApp. Previously this pointed to config.AppDirectory (the real user path), but Upgrade.exe was only copied to OutputDirectory during simulation. Change to OutputDirectory so the simulation doesn't depend on external file system state.
…ctory All simulation artifacts (Client.exe, Upgrade.exe, .server, report) now live in the same AppDirectory where the update is targeted. Changes: - Remove OutputDirectory from SimulateConfigModel - Replace all config.OutputDirectory references with config.AppDirectory - Remove OutputDirectory validation check - Remove SelectOutputDirCommand and OutputDir UI section - Fix --install-path to use AppDirectory (avoid OneDrive real path issues) Closes the issue where StartApp couldn't find Upgrade.exe because it was looking in a real user path instead of the simulation workspace.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.