Batch 2: Wire IUpdateHooks and IUpdateReporter into strategy flows#364
Merged
Conversation
- Resolve hooks and reporter in GeneralUpdateBootstrap.LaunchWithStrategy and inject into all three strategies (Client/Upgrade/OSS) - ClientUpdateStrategy: call hooks at key lifecycle points: OnBeforeUpdateAsync (can cancel), OnBeforeStartAppAsync, OnUpdateErrorAsync Report UpdateStarted, DownloadCompleted, UpdateFailed - UpgradeUpdateStrategy: call hooks at key lifecycle points: OnBeforeUpdateAsync, OnAfterUpdateAsync, OnBeforeStartAppAsync, OnUpdateErrorAsync Report UpdateApplied, UpdateFailed - OSSUpdateStrategy: call hooks at key lifecycle points: OnBeforeUpdateAsync, OnBeforeStartAppAsync, OnUpdateErrorAsync Report UpdateStarted, UpdateApplied, UpdateFailed - All hook/reporter calls use safe wrappers that log and swallow exceptions to prevent hooks from breaking the update flow Closes #363
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the existing IUpdateHooks and IUpdateReporter interfaces into the three strategy flows (Client/Upgrade/OSS).
Changes
GeneralUpdateBootstrap
ClientUpdateStrategy
UpgradeUpdateStrategy
OSSUpdateStrategy
All hook/reporter calls use safe wrappers that log and swallow exceptions to prevent hooks from breaking the update flow.
Build
Closes #363