Move ICleanStrategy/IDirtyStrategy to Core — Core owns Differential contracts#385
Merged
Conversation
…nd Core - Create ICleanStrategy and IDirtyStrategy in Core.Differential namespace - Update AbstractBootstrap extension points to use the actual interface types: CleanStrategy<T>() where T : ICleanStrategy, new() DirtyStrategy<T>() where T : IDirtyStrategy, new() - Differential interfaces become backward-compatible aliases extending Core's - Default implementations use the local (Differential) interface types This satisfies: Core owns the canonical interface definitions. Differential references Core (via ProjectReference) and implements them. No circular dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the ICleanStrategy and IDirtyStrategy interface definitions into Core, so Core truly owns them. Differential keeps backward-compatible aliases that extend Core's interfaces.
Architecture
Core (owns interfaces)
├── ICleanStrategy
├── IDirtyStrategy
└── IBinaryDiffer
Differential → Core (implements Core's interfaces)
├── ICleanStrategy : Core.Differential.ICleanStrategy (alias)
├── IDirtyStrategy : Core.Differential.IDirtyStrategy (alias)
├── DefaultCleanStrategy : ICleanStrategy
├── DefaultDirtyStrategy : IDirtyStrategy
└── IBinaryDiffer : Core.Differential.IBinaryDiffer (alias)
No circular dependency. Differential references Core, not the reverse.
Changes
Build
Related
Addresses the remaining dependency architecture concern.