Fix flaky CleanBackup test: use version-based sorting instead of CreationTime#396
Merged
Conversation
… to fix flaky test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses flakiness in StorageManager.CleanBackup by making backup-retention deterministic: instead of sorting backup directories by filesystem CreationTime, it sorts by the version encoded in the directory name.
Changes:
- Replace
CreationTime-based ordering inStorageManager.CleanBackupwith ordering derived fromVersion.TryParse(directoryName). - Keep the “retain N most recent, delete the rest” behavior unchanged, but make the ordering deterministic for rapidly-created directories.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+308
to
+312
| .OrderByDescending(d => | ||
| { | ||
| var name = d.Name; | ||
| return Version.TryParse(name, out var v) ? v : new Version(0, 0); | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #395
Summary
Fixes 4 pre-existing test failures that were excluded from CI:
Verification
Full CoreTest suite: 259/259 pass, 0 failures (previously 4 failures)