Skip to content

Cleanup unused files#14290

Open
mattiagiupponi wants to merge 17 commits into
masterfrom
cleanup_dockercompose
Open

Cleanup unused files#14290
mattiagiupponi wants to merge 17 commits into
masterfrom
cleanup_dockercompose

Conversation

@mattiagiupponi

@mattiagiupponi mattiagiupponi commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jun 4, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the docker-compose.yml file to dynamically load environment files using the APP_ENV variable (e.g., .env${APP_ENV}). The reviewer recommends using the ${APP_ENV:-} syntax instead to prevent Docker Compose from throwing warnings when the APP_ENV variable is not defined in the host environment.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docker-compose.yml Outdated
Comment thread docker-compose.yml Outdated
Comment thread docker-compose.yml Outdated
Comment thread docker-compose.yml Outdated
Comment thread docker-compose.yml Outdated
@mattiagiupponi mattiagiupponi marked this pull request as ready for review June 4, 2026 13:35
Comment thread docker-compose.yml Outdated
@mattiagiupponi mattiagiupponi changed the title Cleanup dockercompose Cleanup unused files Jun 5, 2026
@gitguardian

gitguardian Bot commented Jun 8, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Bearer Token 5eaf9e8 docs/src/development/api.md View secret
9468526 Triggered Generic Password 68d92cc .env_dev View secret
863333 Triggered Generic Password 68d92cc .env_dev View secret
863333 Triggered Generic Password 68d92cc .env_dev View secret
59204 Triggered Django Secret Key 68d92cc .env_dev View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@mattiagiupponi mattiagiupponi force-pushed the cleanup_dockercompose branch from aa81e2e to 021ff9e Compare June 9, 2026 14:55
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.91%. Comparing base (0495358) to head (68d92cc).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #14290   +/-   ##
=======================================
  Coverage   74.91%   74.91%           
=======================================
  Files         982      982           
  Lines       60496    60496           
  Branches     8247     8247           
=======================================
  Hits        45319    45319           
  Misses      13346    13346           
  Partials     1831     1831           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattiagiupponi mattiagiupponi modified the milestones: 5.1.0, 5.2.0 Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants