Repository navigation
Raise zip entry cap to 16 GiB - #4
Merged
Merged
Conversation
gb/countrywide ships AddressBase Core as a single CSV whose zip entry declares 9,043,535,569 bytes, over the 8 GiB per-entry cap, so every run of the source fails. The default cap is now 16 GiB. Claude-Session: https://claude.ai/code/session_01M9dZ4UWYaMwr9e9cwwKpyS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
gb/countrywide(ChopChop source 2900) has failed every run since at least 2026-09-23. AddressBase Core ships as one CSV in a zip, and that entry declares 9,043,535,569 bytes, which is over the 8 GiB per-entry cap from #3:(The log shows the old 2 GiB cap because the deployed image predates #3. The 8 GiB cap would still refuse it.)
Change
MAX_ZIP_ENTRY_BYTESgoes from 8 GiB to 16 GiB.BATCH_MACHINE_MAX_ZIP_ENTRY_BYTESstill overrides it.Testing
python3 -m unittest openaddr.tests.conform.TestZipDecompressTaskin the Docker image: 10 tests pass.Rollout
Build amd64, push
registry.geocod.io/geocodio/batch-machine:latest,docker pullon the proxy host, then re-run source 2900.https://claude.ai/code/session_01M9dZ4UWYaMwr9e9cwwKpyS