Repository navigation
feat(combobox): filter prop to replace the default matcher - #4
Merged
Merged
Conversation
Adds jsdom and Testing Library as dev dependencies so the Combobox can be exercised with real typing. Claude-Session: https://claude.ai/code/session_019z4Ci4N7EEQPRtk3kAoZeS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
filter(option, query)prop toCombobox, passed through to Base UI'sCombobox.Root. Omitted, the default matcher is unchanged.Bullpen needs it for a fuzzy project picker (typing "gaz app" should find "Gazetteer append"), which Base UI's built-in contains-match cannot do.
Tests: a new
Combobox.test.tsxtypes the same query with and withoutfilterand asserts the listed options differ. It runs under a per-file jsdom environment; jsdom and Testing Library are dev-only and not shipped.https://claude.ai/code/session_019z4Ci4N7EEQPRtk3kAoZeS