Skip to content

fix(uuid): better handle too many generation #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 2 commits into from
Feb 9, 2026
Merged

fix(uuid): better handle too many generation #1232

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a89255
fix(uuid): better handle too many generation
BotellaA Feb 8, 2026
2daface
revert
BotellaA Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/geode/basic/uuid.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,14 @@ namespace geode
{
uuid::uuid()
{
static constexpr index_t MAX_SAFETY_COUNT = 1000;
static constexpr absl::Duration INITIAL_SLEEP =
absl::Microseconds( 100 );
static constexpr absl::Duration MAX_SLEEP = absl::Milliseconds( 50 );
UUIDv7Generator gen;
bool generated{ false };
for( const auto i : Range{ 10 } )
auto sleep = INITIAL_SLEEP;
for( const auto i : Range{ MAX_SAFETY_COUNT } )
{
geode_unused( i );
if( auto bytes = gen.generate() )
Expand All @@ -250,6 +255,8 @@ namespace geode
generated = true;
break;
}
absl::SleepFor( sleep );
sleep = std::min( sleep * 2., MAX_SLEEP );
}
OPENGEODE_EXCEPTION( generated, "[uuid] could not generate uuid" );
}
Expand Down Expand Up @@ -316,4 +323,4 @@ namespace std
{
return absl::HashOf( uuid.bytes_ );
}
} // namespace std
} // namespace std