Skip to content

perf(BijectiveMapping): reduce queries to maps #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 1 commit into from
Feb 15, 2026
Merged

perf(BijectiveMapping): reduce queries to maps #1234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions include/geode/basic/mapping.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,50 +133,48 @@ namespace geode

void map( const T1& in, const T2& out )
{
if( this->has_mapping_input( in ) )
auto [in_itr, in_is_new] =
this->in2out_mapping().emplace( in, out );
if( !in_is_new )
{
erase_in( in );
this->out2in_mapping().erase( in_itr->second );
in_itr->second = out;
}
if( this->has_mapping_output( out ) )
auto [out_itr, out_is_new] =
this->out2in_mapping().emplace( out, in );
if( !out_is_new )
{
erase_out( out );
this->in2out_mapping().erase( out_itr->second );
out_itr->second = in;
}
emplace( in, out );
}

void erase_in( const T1& in )
{
if( !this->has_mapping_input( in ) )
auto in_itr = this->in2out_mapping().find( in );
if( in_itr == this->in2out_mapping().end() )
{
return;
}
const auto out = this->in2out( in );
this->in2out_mapping().erase( in );
this->out2in_mapping().erase( out );
this->out2in_mapping().erase( in_itr->second );
this->in2out_mapping().erase( in_itr );
}

void erase_out( const T2& out )
{
if( !this->has_mapping_output( out ) )
auto out_itr = this->out2in_mapping().find( out );
if( out_itr == this->out2in_mapping().end() )
{
return;
}
const auto in = this->out2in( out );
this->in2out_mapping().erase( in );
this->out2in_mapping().erase( out );
this->in2out_mapping().erase( out_itr->second );
this->out2in_mapping().erase( out_itr );
}

[[nodiscard]] index_t size() const
{
return this->size_input();
}

private:
void emplace( const T1& in, const T2& out )
{
this->in2out_mapping().emplace( in, out );
this->out2in_mapping().emplace( out, in );
}
};

template < typename T >
Expand Down