Fix solver selection fallback and invalid PyOptInterface exception handling#135
Open
RiyanshiTomar wants to merge 2 commits intoGeomScale:developfrom
Open
Fix solver selection fallback and invalid PyOptInterface exception handling#135RiyanshiTomar wants to merge 2 commits intoGeomScale:developfrom
RiyanshiTomar wants to merge 2 commits intoGeomScale:developfrom
Conversation
…-error-handling Fix solver selection fallback and invalid PyOptInterface exception handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved : #134
-> Add a resolve_solver_name() helper and use it in fba, fva, inner_ball, set_model, and remove_redundant_facets to centralize default-solver resolution and only apply the default when no solver is explicitly provided.
->Replace invalid except poi.TerminationStatusCode.* handlers with generic exception handling that raises contextual RuntimeErrors for FBA, FVA, and redundant-facet removal so underlying errors are not masked.
->Propagate the solver choice from the MetabolicNetwork into PolytopeSampler.get_polytope() when the sampler's _parameters["solver"] is None, and pass the resolved solver_name into remove_redundant_facets() so preprocessing uses the intended solver.
Description
-> Add resolve_solver_name() helper to centralize default solver resolution
-> Propagate solver choice from MetabolicNetwork to PolytopeSampler preprocessing
-> Replace invalid exception handlers catching enum values with proper RuntimeError
-> Surface underlying solver errors instead of masking them with print statements
Please merge this pull request.