Repository navigation
D2: a door plane states its busbar_bucket_tokens model label; no control byte or internal lane key reaches /metrics - #577
Merged
Conversation
…abel; no internal lane key reaches /metrics
The money gauge rendered the ledger's lane key verbatim as its `model` label, so a door plane's
rows were scraped as `model="<plane>\u{1f}<entry>"` and its fee lane as `model="<plane>\u{1f}"`.
The root now states, per door plane, the label each of its money lane keys is scraped under
(`door_money_labels`: an entry's key -> "<scope>/<entry>", the plane fee lane -> "<scope>"),
carried on the egress's DoorBreaker and kept by DoorCells as a sticky map (the ledger keeps a
key's history after an apply retires it). money.rs renders the stated label opaquely; an
unstated key that is a plain name keeps its bytes (the llm plane, unchanged); any other key, or a
stated label carrying a control byte or the separator, emits no series.
Tests: kernel `metrics::money::tests` (the label rule; a door plane's rows on the scrape under
its stated labels, sticky across a generation); root
`no_label_on_the_scrape_carries_a_control_byte_or_the_lane_separator` (the llm rig and the
decisions door with keyed traffic, every label value of every family scanned).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #559 (base
p6-d2-step4). This is the ARCHITECT ruling: the money gauge's 0x1F leak plus a guard for the whole class, as its own PR right after 4a.The defect.
busbar_bucket_tokensrendered the money ledger's lane key verbatim as itsmodellabel. For a door plane that key is the kernel's internal"<plane>\x1f<entry>", or its fee lane"<plane>\x1f". Measured on the scrape:busbar_bucket_tokens{bucket="vk_…",model="decision\x1f",tier="input"} 0.The fix: the same plane-stated label rule as #559.
DoorBreaker::modelsmaps each ledger lane key a door plane writes to themodellabel it is scraped under. The root states these throughdoor_money_labels:"<scope>/<entry>""<scope>"DoorCellskeeps these labels sticky across generations, because the ledger keeps a key's history after an apply retires it.metrics/money.rsrenders the label the plane stated. When no label was stated, it renders the key itself only if the key is a plain name: that is the llm plane's bare model, so its 1.5.5 bytes are unchanged.The class guard. Root
serve::door_tests::no_label_on_the_scrape_carries_a_control_byte_or_the_lane_separator:PLANE_LANE_SEP.model="m0"and the decisions fee lane asmodel="<section>".metrics::money::testspins the label rule:<scope>/<entry>and<scope>render;a label value carries a control byte or the lane separator ("decision\u{1f}"): busbar_bucket_tokens{bucket="vk_…",model="decision^_",tier="input"} 0. The kernel label tests also fail.Proof (Latchkey)
-D warnings)root_key_spellingbusbar --bin(default)busbar --bin --all-features(door_tests, door_steps)Oracle, llm metrics and money cells (base 3182e56 vs production head 0fc8fac030, engine 4a7a7bba). The PR head differs from 0fc8fac030 only in a test file.
replay --baseline-version 1.5.5 --strict --id-filter '^(ops\.scrape\|metrics|neutrality\|metrics|documented\|changelog\|spend-metrics|billing\.?[^|]*\||money\.?[^|]*\||ledger\.?[^|]*\||usage\.[^|]*\||crosscut\.traps\|)'25717607…d418b7on both sides).