Repository navigation
K1-10 / Q-STEP9-a: pools is reserved; the strip runs at exact depths; an entry named after a reserved key is refused - #728
Merged
Conversation
…xact depths; an entry named after a reserved key is refused at load ARCHITECT ruling 2026-10-07 (spec BUSBAR-1.6.0.md :561-570, decision #47): - `pools` (busbar_contract::section::RESERVED_POOLS_KEY) joins the deal's reserved sub-keys. - deal::strip takes reserved keys at exactly four depths, no recursion: the section, each registration, each pool (pools.<p>) and each member (pools.<p>.members[i]); every key is recorded at its path. Under a declared verb the whole `pools` subtree leaves and its pools' and members' keys are recorded too. - The root `pools:` section keeps 1.5.5's two reserved words (hooks, upstream_credentials); a pool named tier/work/breaker/rate_card/... is a pool and crosses. - spec :567 generic refusal: a declared-verb section's depth-1 entry named after a reserved key whose value is plainly not that knob is refused at load (--validate and boot), at the entry's own path and position, in reserved_name_refusal's sentence (1.5.5's bytes for the two section words). Carried onto predev (orphaned stack #599): predev's entry `timeout` (4757514, R2-G) stays a reserved sub-key beside `pools` (nine keys), and the shape judge reads it as a scalar, so an entry named `timeout` is refused like any other reserved name.
…TION_KEYS (root_key_spelling)
…ted with an example of what slips through
…y pool), as the shape judge and pool reader read it
MattJackson
enabled auto-merge
October 10, 2026 06:09
promote into
|
| gate | row | detail |
|---|---|---|
| construction | one-pick-site |
3 production call site(s) of 'pick_among(' (ceiling 2): crates/busbar-kernel-egress/src/walk.rs:298; crates/busbar-llm/src/engine/exhaustion/fallback.rs:120; crates/busbar-llm/src/engine/pipeline.rs:8 |
| kind-isolation | kind-isolation:deps |
3 finding(s), 93 shipped edge instance(s) over 30 class(es), 93 declaration(s); 56 '[[dep]]' row(s), 0 question(s): unlisted-dep-edge legacy -> plane busbar-llm -> busbar-plane-llm is a shipped edge w |
| kind-isolation | kind-isolation:test-deps |
3 finding(s), 35 test edge instance(s) over 21 class(es), 35 declaration(s); 20 '[[dep]]' row(s), 0 question(s): unlisted-dep-edge cleanliness -> legacy busbar-core-admin -> busbar-a2a is a test edge |
| kind-isolation | kind-isolation:law0 |
11 hit(s) off the [[law0]] ceilings, 5 finding(s) over 14 neutral crate(s): law0-rise busbar × instance:secret 37 hit(s) against a ceiling of 35: this landing grew a neutral crate's instance vocabular |
| kind-isolation-ship | kind-isolation:deps |
10 finding(s) over 93 shipped edge(s): ship-edge kernel -> hooks busbar-kernel -> busbar-hook-ranking is 'not-allowed': the architecture grants no kernel -> hooks edge, and the ship criterion is the a |
| kind-isolation-ship | kind-isolation:test-deps |
10 finding(s) over 35 test edge(s): ship-edge cleanliness -> export busbar-core-admin -> busbar-export-prometheus is 'not-allowed': the architecture grants no cleanliness -> export edge, and the ship |
| kind-isolation-ship | kind-isolation:law0 |
11 hit(s) off the [[law0]] ceilings, 5 finding(s) over 14 neutral crate(s): law0-rise busbar × instance:secret 37 hit(s) against a ceiling of 35: this landing grew a neutral crate's instance vocabular |
| kind-isolation-ship | kind-isolation:faces |
2 finding(s) over 40 crate(s): foreign-entry crates/busbar busbar is kind 'root' and implements 'Transport' 1 time(s) in shipped source — the entry face of kind 'transport'. A trait implementation is |
| kind-isolation-ship | kind-isolation:legacy-drain |
3 finding(s): transitional-live qa/kind-isolation.toml 'busbar-a2a -> busbar-core-admin' (legacy drain: the retiring A2A engine's tests drive the admin surface that drained into the cleanliness tier) |
| ship-ready | ship-ready:ship-twin |
'kind-isolation-ship' is not green: kind-isolation:deps (a dependency the architecture does not grant is still in the graph); kind-isolation:test-deps (a dependency the architecture does not grant is |
| structure-lint | structure-lint:plane-dup:unledgered |
22 finding(s): PLANE-DUPLICATE (module): 'config.rs' — a2a:crates/busbar-a2a/src/a2a/config.rs decisions:crates/busbar-plane-decisions/src/config.rs voice:crates/busbar-voice/src/config.rs (the ledger |
Judged against base bd3947661: 0 new red, 0 worse, 5 standing (excused).
tests passed: 24304, failed: 0. Run: https://github.com/GetBusbar/busbar/actions/runs/38054211991 . Artifact verdict-d29f33cdd3b6d823aa0adb05383b82b077d40d4a (failures.json, junit.xml, raw.log; 90 days).
…plane as p-pools, not p-llm (a new llm leak in the composition root)
MattJackson
added this pull request to the merge queue
Oct 10, 2026
MattJackson
removed this pull request from the merge queue due to a manual request
Oct 10, 2026
MattJackson
added this pull request to the merge queue
Oct 10, 2026
MattJackson
removed this pull request from the merge queue due to a manual request
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
K1-10 / Q-STEP9-a, carried onto predev from the orphaned #599 (it sat on #559 → #554 → #546 → p6-d2-kernel, whose #526 closed unmerged). Supersedes #599, minus #670 (P1b), which predev cannot take as written; that is its own task.
Authority.
BUSBAR-1.6.0.mdPart 0 §4 (predev 9c0a394):poolssub-key.ARCHITECT Q-STEP9-a, 2026-10-07. On predev
docs/design/1.6.0-QUESTIONS.mdstill sayspoolsis not reserved: under a declared verb,<verb>.pools.<p>.breaker/tierandmembers[i].tierreached the plane's validate.Changes
config_validate::deal::striptakes the reserved keys at EXACT depths, and nowhere else:pools.<p>);pools.<p>.members[i]).poolsis reserved and leaves whole. Under the rootpools:section every depth-1 key is a pool, as in 1.5.5, so a pool namedtier,workorbreakeris a pool and crosses.--validateand boot), at the entry's own path and position, insection::reserved_name_refusal's sentence (1.5.5's bytes for the two section words).RESERVED_SECTION_KEYS(root_key_spelling).Merge with predev. Predev's entry
timeout(4757514, R2-G) stays a reserved sub-key besidepools, so there are nine. The shape judge readstimeoutas a scalar. So an entry namedtimeoutis refused like every other reserved name instead of being silently stripped; the cells are inred_a_value_plainly_not_its_knob_names_an_entry.REDs (kept from #599)
red_each_exact_depth_is_stripped_and_recorded_at_its_path,red_root_pools_named_after_a_knob_are_pools_and_cross,red_a_value_plainly_not_its_knob_names_an_entry;red_3g_deals_a_root_pool_named_after_a_knob_as_a_pool;cli_validaterefusal cell.Proof (Latchkey, this tree)
cargo check --workspace --all-targetsclippy -p busbar-contract --all-targets -D warningsclippy -p busbar-kernel --all-targets -D warningsclippy -p busbar --all-targets -D warningstest -p busbar-contracttest -p busbar-kerneltest -p busbar-plane-mcptest -p busbar-plane-a2atest -p busbar-plane-decisionstest -p busbar-plane-llmtest -p busbar-plane-streamingtest -p busbarserve-framed-wildpublication under one-process cargo test; CI's test:workspace runs under nextest)