Prevent tracking channel states for malformed CIDs#6497
Draft
gpunto wants to merge 1 commit into
Draft
Conversation
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
c94969e to
7fd715c
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Goal
Prevent the SDK from tracking
ChannelStates by a malformed cid. The original symptom is inSyncManager.updateActiveChannels: it issues aFilters.in("cid", missingCids)query on reconnect, and a single malformed entry in the list fails the whole request, blocking re-watch for every valid channel in the same batch. The underlying problem is thatStateRegistry/LogicRegistryhappily store state keyed by an unvalidated(channelType, channelId)pair, so malformed cids can leak in through any code path that bypasses the existingvalidateCidWithResultgates (sync recovery,channelFromMessage, etc.).Closes AND-1187.
Implementation
ChannelIdvalue class withfromCid/fromTypeAndIdfactories that returnnullon invalid input.StateRegistryandLogicRegistryre-key their channel maps onChannelId. Their publicchannel(type, id)entry points validate at the boundary; malformed input returns a fresh, non-cached state/logic.StateRegistry.getActiveChannelStates()now returnsMap<ChannelId, ChannelState>, soSyncManager.updateActiveChannelsandEventHandlerSequentialiterate validated keys directly.QueryChannelsStateLogic.addChannelsStatefilters out malformed server channels upfront so they never reachsetCids/setChannels/logicRegistry.Testing
ChannelIdTestcoversfromCid/fromTypeAndId.StateRegistryTestandLogicRegistryTest: malformed cid returns a non-cached state/logic and the registry maps stay empty.QueryChannelsStateLogicTest:getActiveChannelStatereturns null on malformed cid;addChannelsStatedrops malformed channels fromsetCids/setChannels/logicRegistry.