Migrate partial message update and reminder request bodies to generated models - #6608
Draft
gpunto wants to merge 3 commits into
Draft
Migrate partial message update and reminder request bodies to generated models#6608gpunto wants to merge 3 commits into
gpunto wants to merge 3 commits into
Conversation
…tialRequest network model
…dateReminderRequest network models
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Goal
Migrate the partial-message-update and reminder request bodies (
partialUpdateMessage,createReminder,updateReminder) to the generatedUpdateMessagePartialRequest,CreateReminderRequest, andUpdateReminderRequestnetwork models.Part of AND-1291
Implementation
UpdateMessagePartialRequest,CreateReminderRequest,UpdateReminderRequest; remove the hand-writtenPartialUpdateMessageRequestandReminderRequest.MoshiChatApimappers and the message/reminder@Bodytypes retyped to the generated models.Testing
MessageAndReminderRequestAdapterTestlocks the wire shape, including theremind_atdate format and theset/skip_enrich_url/skip_pushfields.spotlessApply,apiDump(no public-API change),detekt, and the full clienttestDebugUnitTestsuite pass.