Repository navigation
Conversation
laevandus
commented
Oct 28, 2026
|
|
||
| gem 'fastlane-plugin-versioning' | ||
| gem 'fastlane-plugin-stream_actions', '0.4.9' | ||
| gem 'fastlane-plugin-stream_actions', git: 'https://github.com/GetStream/fastlane-plugin-stream_actions.git', branch: 'optional-sdk-names' |
Generated by 🚫 Danger |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves: IOS-2225
🎯 Goal
Run CI tests on
Package.swiftso they build with the same settings SPM consumers get, and remove the Xcode project.📝 Summary
scanon the package (StreamCore-Packagescheme with-only-testing:<Target>Tests) instead of the Xcode framework targetsGithubfile) instead of slatherInfo.plistversions; the SDK version stays inSystemEnvironment+Version.swiftStreamCore.xcodeproj,Sources/*/Info.plist, the test plans and.slather.ymlfastlane-plugin-stream_actionstemporarily points at theoptional-sdk-namesbranch until the plugin is released🛠 Implementation
The Xcode framework targets built with an iOS 15.0 deployment target and compiled StreamAttachments in Swift 5 mode. Consumers get iOS 13 and Swift 6 from
Package.swift. CI now builds exactly what consumers build.The Sonar project version now comes from
SystemEnvironment+Version.swift. Before,get_version_numberreturned1.0, which the version regex didn't match, so the version was empty.🎨 Showcase
🧪 Manual Testing Notes
Open
Package.swiftin Xcode, or runbundle exec fastlane test_core device:"iPhone 17 Pro". The coverage step needsxcresultparserinstalled locally.☑️ Contributor Checklist
docs-contentrepo