fix(samples): match the share call accordion to design - #1343
Draft
renefloor wants to merge 2 commits into
Draft
Conversation
The card now sits 8 inside the participant tile on every side, which is where the participant label sits, so their edges line up. Its inset is read from the grid's own padding instead of being a fixed 24. Contents follow the design too: full-width "Add Others" and "Copy Call ID" buttons 8 apart, the QR panel on a surface fill with its caption underneath, core icons throughout, and an elevation-3 shadow under the card. A phone gives the card the width between the insets; a wider window centres it at 360. The copy confirmation also loses its hardcoded text colour, which had gone black on the dark SnackBar. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The design system ships a snackbar, and its success variant already carries the checkmark this was hand-assembling. A StreamSnackbarScope sits above the router so any route can reach a messenger. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #1343 +/- ##
=====================================
Coverage ? 31.16%
=====================================
Files ? 374
Lines ? 28789
Branches ? 0
=====================================
Hits ? 8972
Misses ? 19817
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the "Your Meeting is Live!" card in the sample app in line with Video / iOS / Share Call Accordion (mobile frame, web frame).
Spacing
In the design the card sits 8 inside the participant tile on every side — the same 8 the participant label pill sits at — so their edges line up. We used a flat
EdgeInsets.all(24), so nothing did.The inset is now derived rather than hardcoded: the grid's own padding, read from
StreamCallParticipantsGridTheme, plusspacing.xs. That matters because the sample app overrides the grid padding to 4, so a fixed 16 would have missed the label by 4.Measured on device against the design:
Contents
tapTargetSize: shrinkWrap— the default padded target grows each 40 pill to 48 and would double the designed gap; a full-width button keeps a large tap area without it.backgroundSurfacepanel with its caption underneath instead of above, and the explanatory sentence and the raw call id in the button label are gone.context.streamIcons(userAddFill,copyFill,chevronUp/chevronDown,checkmark) rather than Material's.MaterialatstreamElevation.level3with the border in a foregroundDecoratedBox.medium/largebucket centres it at 360, as the web frame draws it.The "Call ID copied to clipboard" confirmation moves from a Material
SnackBarto the design system'sStreamSnackbar, whosesuccessvariant already carries the checkmark the old one hand-assembled. AStreamSnackbarScopesits above the router inMaterialApp.router's builder so any route can reach a messenger. The old bar also rendered its text black on black, from a hardcoded colour that is now gone.Verification
Run on the iPhone 18 Pro and iPad (A16) simulators; widget bounds read out of the running app and cross-checked against the Figma geometry — the table above. Copy verified through
simctl pbpaste. No golden tests cover this widget.🤖 Generated with Claude Code