fix(samples): no encryption where the platform cannot do it - #1345
fix(samples): no encryption where the platform cannot do it#1345renefloor wants to merge 1 commit into
Conversation
Only Android, iOS and macOS ship the encryption manager, so the lobby's switch is gone everywhere else and the card says why. An encrypted call opened there says it cannot be joined and the join button stays disabled. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #1345 +/- ##
=====================================
Coverage ? 31.16%
=====================================
Files ? 374
Lines ? 28789
Branches ? 0
=====================================
Hits ? 8972
Misses ? 19817
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The lobby offered end-to-end encryption on web, where
EncryptionManager.isSupportedis false: the switch was live, the call was created withautoOn, and only_attachE2EE— long after creation — checked the platform. Joining a call somebody else had encrypted was equally unguarded.Only Android, iOS and macOS ship the encryption manager. Everywhere else:
getOrCreatenever asks forautoOn, so no encrypted call can be created there;_joinCallPressedrefuses anyway — the button is not the only way in (a deep link, or a host drivingStreamLobbyView) — and refuses again after creation, sincegetOrCreatecan turn up a call someone else created encrypted;Sample app only; no SDK change.
Testing
Ran the sample on Chrome from this branch: a new call shows the unsupported card, and the existing encrypted
teste2ecall shows the blocked card with the join button greyed out.🤖 Generated with Claude Code