Skip to content

fix(samples): no encryption where the platform cannot do it - #1345

Open
renefloor wants to merge 1 commit into
v2from
fix/e2ee-unsupported-platforms
Open

fix(samples): no encryption where the platform cannot do it#1345
renefloor wants to merge 1 commit into
v2from
fix/e2ee-unsupported-platforms

Conversation

@renefloor

@renefloor renefloor commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

The lobby offered end-to-end encryption on web, where EncryptionManager.isSupported is false: the switch was live, the call was created with autoOn, and only _attachE2EE — long after creation — checked the platform. Joining a call somebody else had encrypted was equally unguarded.

Only Android, iOS and macOS ship the encryption manager. Everywhere else:

  • the card drops the switch and the key field and says "Not supported on this platform";
  • an encrypted call reads "This call is encrypted and cannot be joined on this platform", in warning colours, with the join button disabled;
  • getOrCreate never asks for autoOn, so no encrypted call can be created there;
  • _joinCallPressed refuses anyway — the button is not the only way in (a deep link, or a host driving StreamLobbyView) — and refuses again after creation, since getOrCreate can turn up a call someone else created encrypted;
  • an invite key in the URL is ignored for a call that does not exist yet, rather than creating a call web would then be locked out of. An invite to an existing encrypted call still lands on the blocked card.

Sample app only; no SDK change.

Testing

Ran the sample on Chrome from this branch: a new call shows the unsupported card, and the existing encrypted teste2e call shows the blocked card with the join button greyed out.

🤖 Generated with Claude Code

before after
image e2ee-unsupported
image image-1789133870227

Only Android, iOS and macOS ship the encryption manager, so the lobby's
switch is gone everywhere else and the card says why. An encrypted call
opened there says it cannot be joined and the join button stays disabled.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4223624c-bbdc-410f-9add-d4e38fcbbb49

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@renefloor
renefloor marked this pull request as ready for review September 11, 2026 13:44
@renefloor
renefloor requested a review from a team as a code owner September 11, 2026 13:44
@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v2@ad336b1). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #1345   +/-   ##
=====================================
  Coverage      ?   31.16%           
=====================================
  Files         ?      374           
  Lines         ?    28789           
  Branches      ?        0           
=====================================
  Hits          ?     8972           
  Misses        ?    19817           
  Partials      ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant