fix: exclude RCT-Folly from prebuilt RN modes#2150
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThree podspec files are modified to conditionally include the RCT-Folly dependency based on environment variables (RCT_USE_PREBUILT_RNCORE and RCT_USE_RN_DEP) when using prebuilt React Native core or dependencies. The dependency is only added when neither prebuilt flag is enabled. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
closed in favour of #2151 |
💡 Overview
📝 Implementation notes
🎫 Ticket: https://linear.app/stream/issue/XYZ-123
📑 Docs: https://github.com/GetStream/docs-content/pull/
This is a port of this fix that was just added on the Chat SDK. All details are explained in the PR.
To reproduce, simply run:
for RN versions
<= 0.80.Xor
for RN versions
>= 0.81.X.Summary by CodeRabbit