Skip to content

fix: exclude RCT-Folly from prebuilt RN modes#2150

Closed
isekovanic wants to merge 1 commit intomainfrom
fix/exclude-rct-folly-from-prebuilt-modes
Closed

fix: exclude RCT-Folly from prebuilt RN modes#2150
isekovanic wants to merge 1 commit intomainfrom
fix/exclude-rct-folly-from-prebuilt-modes

Conversation

@isekovanic
Copy link
Contributor

@isekovanic isekovanic commented Mar 3, 2026

💡 Overview

📝 Implementation notes

🎫 Ticket: https://linear.app/stream/issue/XYZ-123

📑 Docs: https://github.com/GetStream/docs-content/pull/

This is a port of this fix that was just added on the Chat SDK. All details are explained in the PR.

To reproduce, simply run:

RCT_NEW_ARCH_ENABLED=1 RCT_USE_RN_DEP=1 pod install --repo-update

for RN versions <= 0.80.X

or

RCT_NEW_ARCH_ENABLED=1 RCT_USE_PREBUILT_RNCORE=1 pod install --repo-update

for RN versions >= 0.81.X.

Summary by CodeRabbit

  • Chores
    • Enhanced dependency configurations in React Native packages for audio processing, video streaming, and video filtering. Updates improve compatibility with prebuilt React Native core installations and reduce configuration conflicts. Changes provide better build flexibility and stability across different installation scenarios and development environments without affecting runtime behavior.

@isekovanic isekovanic requested a review from santhoshvai March 3, 2026 16:55
@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2026

⚠️ No Changeset found

Latest commit: e72b210

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6d4e2d7 and e72b210.

📒 Files selected for processing (3)
  • packages/noise-cancellation-react-native/stream-io-noise-cancellation-react-native.podspec
  • packages/react-native-sdk/stream-video-react-native.podspec
  • packages/video-filters-react-native/stream-io-video-filters-react-native.podspec

📝 Walkthrough

Walkthrough

Three podspec files are modified to conditionally include the RCT-Folly dependency based on environment variables (RCT_USE_PREBUILT_RNCORE and RCT_USE_RN_DEP) when using prebuilt React Native core or dependencies. The dependency is only added when neither prebuilt flag is enabled.

Changes

Cohort / File(s) Summary
Conditional RCT-Folly Dependency
packages/noise-cancellation-react-native/stream-io-noise-cancellation-react-native.podspec, packages/react-native-sdk/stream-video-react-native.podspec, packages/video-filters-react-native/stream-io-video-filters-react-native.podspec
Added conditional logic to include RCT-Folly dependency only when prebuilt React Native core and dependencies are not in use. Environment variables RCT_USE_PREBUILT_RNCORE and RCT_USE_RN_DEP determine whether the dependency is added. Includes explanatory comments for the conditional behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Three specs now dance with logic bright,
Checking flags both left and right,
RCT-Folly joins the fold—
Only when prebuilt's not cold! ✨
Dependencies made conditional and clean,
The wisest pods we've ever seen!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: excluding RCT-Folly dependency from prebuilt React Native modes across three podspec files.
Description check ✅ Passed The description includes the required template structure and provides context (port from Chat SDK), reproduction steps, and ticket reference. However, the Docs PR link is a placeholder () and is incomplete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/exclude-rct-folly-from-prebuilt-modes

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@santhoshvai
Copy link
Member

closed in favour of #2151

@santhoshvai santhoshvai closed this Mar 4, 2026
@santhoshvai santhoshvai deleted the fix/exclude-rct-folly-from-prebuilt-modes branch March 4, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants