feat: added audio capture for ios broadcast screensharing mode - #2346
Draft
greenfrvr wants to merge 1 commit into
Draft
feat: added audio capture for ios broadcast screensharing mode#2346greenfrvr wants to merge 1 commit into
greenfrvr wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle sizeBuilt package output. Sizes in KB; delta vs No significant package size increase vs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Overview
Added audio capturing for iOS broadcast screen sharing type.
Note: if third party app uses exclusive playback category, the call's audio session is interrupted → mic capture stops → nothing is mixed/sent.
📝 Implementation notes
Added
AudioUploaderwhich works similar toSampleUploader: it sends bytes data via socket connection. Server is started on webrtc side. Bytes chunks are accumulated and pushed to ring buffer as they are ready. Audio mixing part stays as is (as it was for in-app audio capturing).🎫 Ticket: https://linear.app/stream/issue/RN-416/ios-broadcast-screen-sharing-audio-capturing
📑 Docs: https://github.com/GetStream/docs-content/pull/1457
Corresponding WebRTC PR: GetStream/react-native-webrtc#58