Merge WebRTC M148 (branch-head 7778)

.agents/skills/gn-check-autofix/SKILL.md

@@ -0,0 +1,72 @@
+---
+name: gn-check-autofix
+description: Automatically fix GN check errors in WebRTC BUILD.gn files. Use when encountering "Include not allowed", "rtc_source_set shall not contain cc files", or when needing to clean up non-absolute dependencies.
+---
+
+# GN Check Autofix
+
+This skill provides instructions for using `tools_webrtc/gn_check_autofix.py` to
+automatically resolve common GN build configuration errors in WebRTC.
+
+## Core Workflows
+
+### Fix Missing Dependencies
+
+When you see "Include not allowed" errors from `gn gen --check`, use this
+workflow:
+
+1. Run the autofix tool on your output directory:
+   ```bash
+   tools_webrtc/gn_check_autofix.py -C <dir>
+   ```
+2. The tool will:
+   - Identify targets missing dependencies.
+   - Add the missing `deps` to the appropriate `BUILD.gn` files.
+   - Automatically run `gn format` on modified files.
+
+### Fix rtc_source_set Violations
+
+If you see "rtc_source_set shall not contain cc files", the tool will
+automatically convert them to `rtc_library`:
+
+1. Run the tool:
+   ```bash
+   tools_webrtc/gn_check_autofix.py -C <dir>
+   ```
+
+### Clean Up Dependencies
+
+To remove all non-absolute dependencies (those not starting with `//`) from
+specific `BUILD.gn` files:
+
+```bash
+tools_webrtc/gn_check_autofix.py -r path/to/BUILD.gn
+```
+
+*Note: This preserves absolute dependencies (starting with `//`) and targets
+ending in `_test`, `_tests`, `_unittest`, or `_unittests`.*
+
+## Integration with Include Cleaner
+
+This tool is the recommended second step after running `webrtc-include-cleaner`.
+While the include cleaner updates your C++ source files, `gn-check-autofix`
+synchronizes your `BUILD.gn` files to match.
+
+## Parameters
+
+- `-C <dir>`: Path to a local build directory (e.g., `out/Default`). The tool
+  internally runs `gn gen --check --error-limit=20000`.
+- `-r <files>`: Remove all non-absolute dependencies from the specified files.
+- `--error-limit`: Can be used to override the default error cap.
+
+## Post-Fix Steps
+
+After the tool runs, always verify the changes:
+
+1. **Deduplicate**: The tool may occasionally add a dependency that is already
+   present. Check the `deps` list for duplicates.
+2. **Regenerate GN**: Run `gn gen <dir>` to confirm errors are resolved.
+3. **Format**: The tool runs `gn format`, but a final `git cl format` is
+   recommended for consistency.
+4. **Review**: Check the diff to ensure dependencies were added to the correct
+   targets.

.agents/skills/gtest-parallel/SKILL.md

@@ -0,0 +1,60 @@
+---
+name: gtest-parallel
+description: Run Google Test binaries in parallel using the gtest-parallel script. Use when needing to speed up test execution, run flaky tests with repeat, or filter specific tests.
+---
+
+# gtest-parallel
+
+`gtest-parallel` is a script that executes Google Test binaries in parallel,
+providing speedup for single-threaded tests and tests that do not run at 100%
+CPU.
+
+## Location
+
+The script is located at `third_party/gtest-parallel/gtest-parallel`.
+
+## Core Flags
+
+### Filtering Tests
+
+Use `--gtest_filter` to run a select set of tests. It supports the same syntax
+as Google Test (including exclusion with `-`).
+
+```bash
+third_party/gtest-parallel/gtest-parallel path/to/binary --gtest_filter=Foo.*:Bar.*
+```
+
+### Timeouts
+
+- `--timeout=TIMEOUT`: Interrupt all remaining processes after the given time
+  (in seconds).
+- `--timeout_per_test=TIMEOUT_PER_TEST`: Interrupt single processes after the
+  given time (in seconds).
+
+### Output and Logging
+
+- `-d OUTPUT_DIR`, `--output_dir=OUTPUT_DIR`: Output directory for test logs.
+  Logs will be available under `gtest-parallel-logs/` inside the specified
+  directory.
+- `--dump_json_test_results=DUMP_JSON_TEST_RESULTS`: Saves the results of the
+  tests as a JSON machine-readable file.
+
+## Advanced Usage
+
+### Repeating Tests (Flakiness Testing)
+
+Use `--repeat=N` to run tests multiple times.
+
+```bash
+third_party/gtest-parallel/gtest-parallel path/to/binary --repeat=1000
+```
+
+### Workers
+
+Use `-w WORKERS` or `--workers=WORKERS` to specify the number of parallel
+workers (defaults to the number of cores).
+
+### Serializing Test Cases
+
+Use `--serialize_test_cases` to run tests within the same test case sequentially
+(useful if they share resources).

.agents/skills/include-cleaner/SKILL.md

@@ -0,0 +1,67 @@
+---
+name: webrtc-include-cleaner
+description: Runs the WebRTC include-cleaner tool (IWYU replacement) to fix headers in C++ files. Use when preparing a CL for upload, after modifying .cc or .h files, or when instructed to fix include regressions.
+---
+
+# WebRTC Include Cleaner
+
+This skill provides instructions for using
+`tools_webrtc/iwyu/apply-include-cleaner`, a tool that automatically manages C++
+`#include` directives in the WebRTC codebase. It ensures that every header used
+is explicitly included and that unused headers are removed.
+
+## When to Use
+
+- **Pre-upload**: Run this tool before uploading a CL to ensure clean includes.
+- **After refactoring**: When moving code or changing dependencies, use this to
+  update `#include` blocks.
+- **Fixing regressions**: Use this if a presubmit or bot identifies
+  include-related issues.
+
+## Basic Usage
+
+To run the include cleaner on specific files:
+
+```bash
+tools_webrtc/iwyu/apply-include-cleaner path/to/file.cc path/to/file.h
+```
+
+To run it on all modified files relative to the upstream branch (ideal for CL
+preparation):
+
+```bash
+tools_webrtc/iwyu/apply-include-cleaner
+```
+
+Note: This is as expensive as a build for each file, so use it sparingly.
+
+## Options
+
+- `-p`, `--print`: Don't modify the files, just print the proposed changes.
+- `-w WORK_DIR`, `--work-dir WORK_DIR`: Specify the GN work directory (default:
+  `out/Default`).
+
+## Post-Execution Steps
+
+After running the include cleaner, it is recommended to perform the following
+steps to ensure build and style consistency:
+
+1. **Check for build errors**: The tool might occasionally make mistakes. Run a
+   build to verify.
+1. **Fix GN dependencies**: Use `tools_webrtc/gn_check_autofix.py` to fix any
+   `deps` issues caused by include changes.
+   ```bash
+   tools_webrtc/gn_check_autofix.py -C out/Default
+   ```
+1. **Format code**: Run `git cl format` to fix any formatting issues in the
+   `#include` blocks.
+   ```bash
+   git cl format
+   ```
+
+## Prerequisites
+
+- The tool automatically generates `compile_commands.json` in the output
+  directory if `out/Default` exists.
+- `clangd` must be checked out in your `.gclient` file
+  (`"checkout_clangd": True`).

.github/workflows/manual-platform-tests.yml

@@ -312,6 +312,12 @@ jobs:
 
       - name: Build iOS SDK artifact
         working-directory: release-pipeline
+        # M148's build config adds the lld-only flag --ignore-auto-link-option
+        # when Xcode >= 26.4, but the pipeline links with Apple ld (use_lld=false
+        # for Mac Catalyst), which rejects it. Pin Xcode 26.3 until the Catalyst
+        # slices can link with lld again.
+        env:
+          DEVELOPER_DIR: /Applications/Xcode_26.3.app
         run: >-
           bundle exec fastlane ios build
           "root:${{ github.workspace }}/webrtc-tree/.output/src"
@@ -443,12 +449,13 @@ jobs:
           while IFS= read -r framework; do
             command+=(-framework "${framework}")
             if [[ "${ENABLE_DEBUG}" == "true" ]]; then
-              mapfile -t dsyms < <(find "$(dirname "${framework}")" -name "$(basename "${framework}").dSYM" -type d | sort)
-              if [[ "${#dsyms[@]}" -eq 0 ]]; then
+              # macOS runners use bash 3.2, which lacks mapfile.
+              dsym="$(find "$(dirname "${framework}")" -name "$(basename "${framework}").dSYM" -type d | sort | head -n 1)"
+              if [[ -z "${dsym}" ]]; then
                 echo "::warning::Missing dSYM for ${framework}"
                 continue
               fi
-              command+=(-debug-symbols "${dsyms[0]}")
+              command+=(-debug-symbols "${dsym}")
             fi
           done < <(find apple-inputs -name '*.framework' -type d | sort)
 

.github/workflows/publish.yml

@@ -292,6 +292,12 @@ jobs:
 
       - name: Build iOS SDK artifact
         working-directory: release-pipeline
+        # M148's build config adds the lld-only flag --ignore-auto-link-option
+        # when Xcode >= 26.4, but the pipeline links with Apple ld (use_lld=false
+        # for Mac Catalyst), which rejects it. Pin Xcode 26.3 until the Catalyst
+        # slices can link with lld again.
+        env:
+          DEVELOPER_DIR: /Applications/Xcode_26.3.app
         run: >-
           bundle exec fastlane ios build
           "root:${{ github.workspace }}/webrtc-tree/.output/src"
@@ -418,12 +424,13 @@ jobs:
           while IFS= read -r framework; do
             command+=(-framework "${framework}")
             if [[ "${ENABLE_DEBUG}" == "true" ]]; then
-              mapfile -t dsyms < <(find "$(dirname "${framework}")" -name "$(basename "${framework}").dSYM" -type d | sort)
-              if [[ "${#dsyms[@]}" -eq 0 ]]; then
+              # macOS runners use bash 3.2, which lacks mapfile.
+              dsym="$(find "$(dirname "${framework}")" -name "$(basename "${framework}").dSYM" -type d | sort | head -n 1)"
+              if [[ -z "${dsym}" ]]; then
                 echo "::warning::Missing dSYM for ${framework}"
                 continue
               fi
-              command+=(-debug-symbols "${dsyms[0]}")
+              command+=(-debug-symbols "${dsym}")
             fi
           done < <(find apple-inputs -name '*.framework' -type d | sort)
 

.gitignore

@@ -34,11 +34,13 @@
 .cproject
 .gdb_history
 .gdbinit
+.gemini
 .landmines
 .metadata
 .project
 .pydevproject
 .settings
+.siso_failed_targets
 .sw?
 /Makefile
 /base

.gn

@@ -12,8 +12,8 @@ import("//build/dotfile_settings.gni")
 buildconfig = "//build/config/BUILDCONFIG.gn"
 
 # The python interpreter to use by default. On Windows, this will look
-# for vpython3.exe and vpython3.bat.
-script_executable = "vpython3"
+# for python3.exe and python3.bat.
+script_executable = "python3"
 
 # The secondary source root is a parallel directory tree where
 # GN build files are placed when they can not be placed directly
@@ -95,6 +95,8 @@ default_args = {
   # Use Siso instead of Ninja.
   use_siso = true
 
+  clang_unsafe_buffers_paths = "//unsafe_buffers_paths.txt"
+
   # WebRTC must stay in C++20 for longer compared to Chromium.
   use_cxx23 = false
 }

AUTHORS

@@ -168,6 +168,7 @@ Hailin Zhao <lynnworld7@gmail.com>
 Fizz Fang <fangkb555@gmail.com>
 Sai Xu <saixu@qti.qualcomm.com>
 Shunyang Zhang <zsy1522943066@gmail.com>
+Suresh Jain <jainudr1982@gmail.com>
 # END individuals section.
 
 # BEGIN organizations section.
@@ -188,6 +189,7 @@ Hopin Ltd. <*@hopin.to>
 HyperConnect Inc. <*@hpcnt.com>
 Igalia S.L. <*@igalia.com>
 Intel Corporation <*@intel.com>
+Island Technology, Inc. <*@island.io>
 LG Electronics, Inc. <*@lge.com>
 Life On Air Inc. <*@lifeonair.com>
 LiveKit <*@livekit.io>
@@ -223,4 +225,5 @@ Vonage Holdings Corp. <*@vonage.com>
 Wang Qing <wangqing-hf@loongson.cn>
 Wire Swiss GmbH <*@wire.com>
 &yet LLC <*@andyet.com>
+Ahmad Yar <ahmaddurranitrg@gmail.com>
 # END organizations section.