Repository navigation
ci: rebuild Actions on GITHUB_TOKEN with TechEngine reusable workflows - #376
Closed
Seungpyo1007 wants to merge 2 commits into
Closed
Seungpyo1007 wants to merge 2 commits into
Seungpyo1007 wants to merge 2 commits into
Conversation
The previous workflows relayed events to TechEngine and edited the triage project with personal access tokens (ENGINE_TOKEN, PROJECT_TOKEN), so the automation ran under a real account. Bring the automation back with this repo's GITHUB_TOKEN only: every job runs here, calls TechEngine's workflows as reusable workflows, and writes as github-actions[bot] (TechEngine ADR-017). - validate-data and deploy-pages return unchanged; neither used a token. - pr-validation and verify-report call TechEngine's review and Tier 0 workflows on PRs; verify-command does the same for `/verify` comments. - dump-develop checks out TechEngine main instead of the submodule pin and also refreshes data/_verify/status.json (was TechEngine verify-status). - weekly-data runs refresh, ingest or verify-network on demand; it has no schedule until each job has been checked by hand. - bump-engine, notify-engine and pr-metadata are not restored.
A maintainer types `/final-review` on an important PR and TechEngineBot posts one comment (edited in place on re-runs) summarizing the checks on the PR head. Checks are read with GITHUB_TOKEN; TECHENGINEBOT_TOKEN is used only for that comment, and nothing else runs as the bot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Brings back the automation removed in "ci: remove every GitHub Actions workflow", without personal access tokens. Every job runs in this repo and calls TechEngine's workflows as reusable workflows, so this repo's
GITHUB_TOKENdoes the writing asgithub-actions[bot](TechEngine ADR-017).Refs #297
Depends on GetTechAPI/TechEngine#126. Merge that first: these workflows call TechEngine
@main.Workflows
validate-data.ymldeploy-pages.ymlmainpr-validation.ymlverify-report.ymlverify-command.yml/verifycommentdump-develop.ymldevelop(data/)data/_verify/status.json, built from TechEnginemaininstead of the submodule pinweekly-data.ymldevelop. It has no schedule until each job has been checked by handfinal-review.yml/final-reviewcommentbump-engine,notify-engineandpr-metadataare not restored. The TechEngine submodule pointer is bumped by hand.Settings needed after merge
weekly-datacan open PRs.TECHENGINEBOT_TOKEN: a fine-grained token from the TechEngineBot account, limited to this repo, with Pull requests: write only. Until it is set,/final-reviewwrites its result to the job summary only.Testing
actionlint1.7.7 passes on every workflow here. The run used TechEngine's branch versions in place of the remoteuses:references, so inputs, types and permissions were checked against them.final-review.yml, which usesTECHENGINEBOT_TOKENfor its single comment.