Repository navigation
ci: validate only changed records on pull requests - #1
Merged
Merged
Conversation
Every PR validated all 962,384 records, a run that took 117 minutes on Windows. PRs now check just the records they add or modify; pushes to develop and main still run the full check. The validator also enforces the bucket rule the README already states (data/game/<first two slug chars>/<slug>.json). All existing records pass it, and it is what keeps a scoped run from missing a duplicate slug: a duplicate would have to land on the same path.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
python -m app.validate --changed-since HEAD^1(only added/modified records). Pushes todevelop/mainstill validate all 962,384 records.data/game/<first two slug chars>/<slug>.json). All existing records already pass; it also keeps a scoped run from missing a duplicate slug.permissions: contents: read, a concurrency group, and a 15-minute PR timeout.Why
A full validation took 117 minutes per run. Part of trimming GetTechAPI automation to
GITHUB_TOKEN-only, low-load CI — no PATs, bot accounts, schedules or write-backs.Check
python -m pytest -q— 11 passed (2 new: wrong bucket, scoped run)python -m app.validate --changed-since develop— OK