Repository navigation
fix(onboarding): resume the wizard after a reload instead of skipping it - #69
Merged
Gilbert09 merged 2 commits intoOct 13, 2026
Merged
Conversation
A new user connects GitHub in step one of the wizard. If the page then loads fresh before Finish (a reload, an app relaunch, or a return from the GitHub flow in a new page), the first-load check read the GitHub connection as proof of an earlier onboarding. It skipped the rest of the wizard and did not send onboarding_completed. The wizard now stores "started, not finished" on the device when it mounts. The first-load check only skips the wizard when this device has never shown it, which is the returning user on a new machine. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 031a5f4e-000c-4d6c-8a00-331468e7c548
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 031a5f4e-000c-4d6c-8a00-331468e7c548
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
onboarding_completedfor them. A fresh load is a reload, an app relaunch, or a return from the GitHub flow in a new page.useInitialDataLoadtreats any GitHub connection plus no local "onboarded" flag as a returning user on a new device. Connecting GitHub is step one of the wizard, so a user in the middle of the wizard looks the same.onboarding_completed. The other non-finishers show backend network errors or no further activity. This change does not fix those.Origin
Changes
'false'to the existing onboarding key. A device that never showed the wizard has no value for this key.onboarding_completed.onboarding_completedapps/webandapps/desktop, because the renderer is a deliberate fork.Note
A device where somebody opened the wizard and never finished it now shows the wizard on each load until they click Finish. This is the intended gate: GitHub is already connected, so Finish is three clicks away.
How did you test this code?
onboarding.test.tsxsuites: the wizard records that it started, a reload with GitHub connected keeps the wizard, and a new device still skips it. The "keeps the wizard" test fails when the fix is removed.apps/web:npx vitest run: all tests pass.tsc --noEmitis clean. ESLint shows no new findings.apps/desktop:npx jest: all tests pass. One suite (updaterIdleRestart) did not run in the sandbox, because the Electron binary was not installed. This change does not touch that suite.tsc --noEmitis clean. ESLint shows no new findings.github_connect_started→onboarding_completedconversion with the window that this report flagged.Agent context
onboarding_completedfrom the first-load path. That would also count returning users on new devices, which inflates the funnel.Created with PostHog Desktop from this inbox report.
🤖 Generated with Claude Code