Skip to content

don't fail on unknown default model#173

Merged
p- merged 1 commit intomainfrom
p--dont-fail-on-unknown-default-model
Mar 19, 2026
Merged

don't fail on unknown default model#173
p- merged 1 commit intomainfrom
p--dont-fail-on-unknown-default-model

Conversation

@p-
Copy link
Contributor

@p- p- commented Mar 19, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 19, 2026 06:37
@p- p- requested a review from anticomputer as a code owner March 19, 2026 06:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates how DEFAULT_MODEL is chosen in the agent so that an unknown AI_API_ENDPOINT no longer raises an exception during import-time initialization.

Changes:

  • Replaces the ValueError on unknown AI_API_ENDPOINT with a string fallback default model.
  • Keeps environment override behavior via COPILOT_DEFAULT_MODEL.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +44 to 46
default_model = "please-set-default-model-via-env"

DEFAULT_MODEL = os.getenv("COPILOT_DEFAULT_MODEL", default=default_model)
@p- p- merged commit 363bfed into main Mar 19, 2026
13 checks passed
@p- p- deleted the p--dont-fail-on-unknown-default-model branch March 19, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants